From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: Valentin Schneider <valentin.schneider@arm.com>,
catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
maz@kernel.org, suzuki.poulose@arm.com, sudeep.holla@arm.com,
dietmar.eggemann@arm.com, rjw@rjwysocki.net,
peterz@infradead.org, mingo@redhat.com,
vincent.guittot@linaro.org, viresh.kumar@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 6/7] arm64: use activity monitors for frequency invariance
Date: Wed, 26 Feb 2020 10:18:47 +0000 [thread overview]
Message-ID: <20200226101847.GA19513@arm.com> (raw)
In-Reply-To: <18604cef-1e26-96a6-38b3-ab03b1b53b48@arm.com>
Hi Valentin, Lukasz,
On Tuesday 25 Feb 2020 at 09:59:20 (+0000), Lukasz Luba wrote:
[..]
> On 2/24/20 6:40 PM, Valentin Schneider wrote:
> >
> > Ionela Voinescu writes:
> > > +static inline int
> >
> > That should be bool, seeing what it returns.
> >
Will do!
[..]
> > >
> > > +#ifndef arch_cpu_freq_counters
> > > +static __always_inline
> > > +bool arch_cpu_freq_counters(struct cpumask *cpus)
> > > +{
> > > + return false;
> > > +}
> > > +#endif
> > >
> >
> > Apologies for commenting on this only now, I had missed it in my earlier
> > round of review.
> >
> > I would've liked to keep this contained within arm64 stuff until we agreed
> > on a more generic counter-driven FIE interface, but seems like we can't evade
> > it due to the arch_topology situation.
> >
> > Would it make sense to relocate this stub to arch_topology.h instead, at
> > least for the time being? That way the only non-arm64 changes are condensed
> > in arch_topology (even if it doesn't change much in terms of header files,
> > since topology.h imports arch_topology.h)
>
> Or make it as a 'weak' and place it just above the arch_set_freq_scale()
> in arch_topology.c, not touching headers?
Yes, you guys are right, this works better nicely confined to
arch_topology.c/h. As Lukasz suggested, I'll make
arch_cpu_freq_counters (while here, it probably works better renamed to
arch_freq_counters_available) a weak function in arch_topology.c with
its strong definition in arm64/kernel/topology.c.
The diff is large(ish) so I'll push v5 directly with this change.
Thank you both for the review,
Ionela.
next prev parent reply other threads:[~2020-02-26 10:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 14:11 [PATCH v4 0/7] arm64: ARMv8.4 Activity Monitors support Ionela Voinescu
2020-02-24 14:11 ` [PATCH v4 1/7] arm64: add support for the AMU extension v1 Ionela Voinescu
2020-02-24 18:39 ` Valentin Schneider
2020-02-24 14:11 ` [PATCH v4 2/7] arm64: trap to EL1 accesses to AMU counters from EL0 Ionela Voinescu
2020-02-24 14:11 ` [PATCH v4 3/7] arm64/kvm: disable access to AMU registers from kvm guests Ionela Voinescu
2020-02-24 14:11 ` [PATCH v4 4/7] Documentation: arm64: document support for the AMU extension Ionela Voinescu
2020-02-24 14:11 ` [PATCH v4 5/7] cpufreq: add function to get the hardware max frequency Ionela Voinescu
2020-02-24 18:44 ` Valentin Schneider
2020-02-24 14:11 ` [PATCH v4 6/7] arm64: use activity monitors for frequency invariance Ionela Voinescu
2020-02-24 18:40 ` Valentin Schneider
2020-02-25 9:59 ` Lukasz Luba
2020-02-26 10:18 ` Ionela Voinescu [this message]
2020-02-26 9:51 ` Pavan Kondeti
2020-02-26 10:22 ` Ionela Voinescu
2020-02-24 14:11 ` [PATCH v4 7/7] clocksource/drivers/arm_arch_timer: validate arch_timer_rate Ionela Voinescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226101847.GA19513@arm.com \
--to=ionela.voinescu@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).