linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Elliot Berman <eberman@codeaurora.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Trilok Soni <tsoni@codeaurora.org>,
	Prasad Sodagudi <psodagud@codeaurora.org>,
	David Collins <collinsd@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt: psci: Add arm,psci-sys-reset2-type property
Date: Wed, 26 Feb 2020 12:09:19 +0000	[thread overview]
Message-ID: <20200226120918.GA21897@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <1582577858-12410-2-git-send-email-eberman@codeaurora.org>

On Mon, Feb 24, 2020 at 12:57:36PM -0800, Elliot Berman wrote:
> Some implementors of PSCI may relax the requirements of the PSCI
> architectural warm reset. In order to comply with PSCI specification, a
> different reset_type value must be used.

This reads as-if you're saying the firmware isn't spec compliant, and
this is a workaround in order to get the expected behaviour.

Can you please elaborate on what you mean by "relax the requirements"
here? What's your firmware doing or not doing that you want to avoid?

> The alternate PSCI SYSTEM_RESET2 may be used in all warm/soft reboot
> scenarios, replacing the architectural warm reset.

I assume you mean SYSTEM_REET2's SYSTEM_WARM_RESET reset? Please call
that out explicitly by name -- it makes this easier to look up, and
if/when more architectural resets are added the commit message won't
become ambiguous.

> 
> Signed-off-by: Elliot Berman <eberman@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/arm/psci.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml
> index 8ef8542..469256a2 100644
> --- a/Documentation/devicetree/bindings/arm/psci.yaml
> +++ b/Documentation/devicetree/bindings/arm/psci.yaml
> @@ -102,6 +102,11 @@ properties:
>        [1] Kernel documentation - ARM idle states bindings
>          Documentation/devicetree/bindings/arm/idle-states.txt
>  
> +  arm,psci-sys-reset2-param:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +        reset_param value to use during a warm or soft reboot.

A "soft" reboot isn't a PSCI concept, so I'm worried this is just
hooking up magic values for Linux internals.

I'd like to better understand what you're trying to achieve here.

Thanks,
Mark.

> +
>    "#power-domain-cells":
>      description:
>        The number of cells in a PM domain specifier as per binding in [3].
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project

  parent reply	other threads:[~2020-02-26 12:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24 20:57 [PATCH v2 0/3] ARM PSCI: Add support for vendor-specific SYSTEM_RESET2 Elliot Berman
2020-02-24 20:57 ` [PATCH v2 1/3] dt: psci: Add arm,psci-sys-reset2-type property Elliot Berman
2020-02-25 10:55   ` Sudeep Holla
2020-02-26 12:09   ` Mark Rutland [this message]
2020-02-27  0:44     ` Elliot Berman
2020-02-24 20:57 ` [PATCH v2 2/3] firmware: psci: Add support for dt-supplied SYSTEM_RESET2 type Elliot Berman
2020-02-25 11:03   ` Sudeep Holla
2020-02-26  1:37     ` Elliot Berman
2020-02-26 11:59       ` Sudeep Holla
2020-02-26 12:02         ` Sudeep Holla
2020-02-26 12:10   ` Mark Rutland
2020-02-24 20:57 ` [PATCH v2 3/3] arm64: dts: qcom: sm8250: Add vendor-specific PSCI system reset2 type Elliot Berman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200226120918.GA21897@lakrids.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=collinsd@codeaurora.org \
    --cc=eberman@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=psodagud@codeaurora.org \
    --cc=sudeep.holla@arm.com \
    --cc=tsoni@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).