From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Subject: [PATCH 1/4] pwm: pca9685: remove unused duty_cycle struct element
Date: Wed, 26 Feb 2020 14:52:26 +0100 [thread overview]
Message-ID: <20200226135229.24929-1-matthias.schiffer@ew.tq-group.com> (raw)
duty_cycle was only set, never read.
Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
drivers/pwm/pwm-pca9685.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c
index b07bdca3d510..19ac97108a64 100644
--- a/drivers/pwm/pwm-pca9685.c
+++ b/drivers/pwm/pwm-pca9685.c
@@ -69,7 +69,6 @@
struct pca9685 {
struct pwm_chip chip;
struct regmap *regmap;
- int duty_ns;
int period_ns;
#if IS_ENABLED(CONFIG_GPIOLIB)
struct mutex lock;
@@ -272,8 +271,6 @@ static int pca9685_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
}
}
- pca->duty_ns = duty_ns;
-
if (duty_ns < 1) {
if (pwm->hwpwm >= PCA9685_MAXCHAN)
reg = PCA9685_ALL_LED_OFF_H;
@@ -449,7 +446,6 @@ static int pca9685_pwm_probe(struct i2c_client *client,
ret);
return ret;
}
- pca->duty_ns = 0;
pca->period_ns = PCA9685_DEFAULT_PERIOD;
i2c_set_clientdata(client, pca);
--
2.17.1
next reply other threads:[~2020-02-26 13:53 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 13:52 Matthias Schiffer [this message]
2020-02-26 13:52 ` [PATCH 2/4] pwm: pca9685: remove ALL_LED PWM channel Matthias Schiffer
2020-03-30 13:07 ` Thierry Reding
2020-03-30 13:15 ` Thierry Reding
2020-03-30 13:19 ` Andy Shevchenko
2020-03-30 15:38 ` Thierry Reding
2020-03-30 13:34 ` Clemens Gruber
2020-03-30 15:40 ` Thierry Reding
2020-03-30 15:43 ` Thierry Reding
2020-03-30 16:07 ` Clemens Gruber
2020-03-31 12:09 ` (EXT) " Matthias Schiffer
2020-03-31 13:14 ` Clemens Gruber
2020-02-26 13:52 ` [PATCH 3/4] pwm: pca9685: initialize all LED registers during probe Matthias Schiffer
2020-02-26 15:00 ` Uwe Kleine-König
2020-02-26 16:13 ` (EXT) " Matthias Schiffer
2020-03-30 13:07 ` Thierry Reding
2020-02-26 13:52 ` [PATCH 4/4] pwm: pca9685: migrate config/enable/disable to apply Matthias Schiffer
2020-02-26 15:05 ` Uwe Kleine-König
2020-02-26 15:10 ` [PATCH 1/4] pwm: pca9685: remove unused duty_cycle struct element Uwe Kleine-König
2020-02-26 17:03 ` (EXT) " Matthias Schiffer
2020-02-26 19:21 ` Uwe Kleine-König
2020-02-28 13:26 ` (EXT) " Matthias Schiffer
2020-03-30 15:12 ` Clemens Gruber
2020-04-03 23:50 ` Sven Van Asbroeck
2020-04-04 17:35 ` Clemens Gruber
2020-04-04 20:17 ` Sven Van Asbroeck
2020-04-06 9:51 ` Thierry Reding
2020-04-07 13:00 ` (EXT) " Matthias Schiffer
2020-04-09 11:42 ` Sven Van Asbroeck
2020-04-03 23:47 ` Sven Van Asbroeck
2020-04-07 14:46 ` (EXT) " Matthias Schiffer
2020-04-08 8:00 ` Matthias Schiffer
2020-03-30 13:07 ` Thierry Reding
2020-03-30 13:18 ` Andy Shevchenko
2020-03-30 16:02 ` Thierry Reding
2020-03-30 16:10 ` Clemens Gruber
2020-04-01 16:36 ` Clemens Gruber
2020-04-01 17:45 ` Thierry Reding
2020-04-02 7:10 ` (EXT) " Matthias Schiffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226135229.24929-1-matthias.schiffer@ew.tq-group.com \
--to=matthias.schiffer@ew.tq-group.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).