linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Char: tpm_tis_spi_cr50: use new structure for SPI transfer delays
@ 2020-02-26 11:43 Sergiu Cuciurean
  2020-02-26 15:12 ` Jarkko Sakkinen
  2020-02-27  8:03 ` [PATCH v2] tpm: " Sergiu Cuciurean
  0 siblings, 2 replies; 4+ messages in thread
From: Sergiu Cuciurean @ 2020-02-26 11:43 UTC (permalink / raw)
  To: gregkh, linux-integrity, linux-kernel
  Cc: peterhuewe, jarkko.sakkinen, jgg, arnd, Sergiu Cuciurean

In a recent change to the SPI subsystem [1], a new `delay` struct was added
to replace the `delay_usecs`. This change replaces the current
`delay_usecs` with `delay` for this driver.

The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
that both `delay_usecs` & `delay` are used (in this order to preserve
backwards compatibility).

[1] commit bebcfd272df6 ("spi: introduce `delay` field for
`spi_transfer` + spi_transfer_delay_exec()")

Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
---
 drivers/char/tpm/tpm_tis_spi_cr50.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_tis_spi_cr50.c b/drivers/char/tpm/tpm_tis_spi_cr50.c
index 37d72e818335..ea759af25634 100644
--- a/drivers/char/tpm/tpm_tis_spi_cr50.c
+++ b/drivers/char/tpm/tpm_tis_spi_cr50.c
@@ -132,7 +132,12 @@ static void cr50_wake_if_needed(struct cr50_spi_phy *cr50_phy)
 
 	if (cr50_needs_waking(cr50_phy)) {
 		/* Assert CS, wait 1 msec, deassert CS */
-		struct spi_transfer spi_cs_wake = { .delay_usecs = 1000 };
+		struct spi_transfer spi_cs_wake = {
+			.delay = {
+				.value = 1000,
+				.unit = SPI_DELAY_UNIT_USECS
+			}
+		};
 
 		spi_sync_transfer(phy->spi_device, &spi_cs_wake, 1);
 		/* Wait for it to fully wake */
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Char: tpm_tis_spi_cr50: use new structure for SPI transfer delays
  2020-02-26 11:43 [PATCH] Char: tpm_tis_spi_cr50: use new structure for SPI transfer delays Sergiu Cuciurean
@ 2020-02-26 15:12 ` Jarkko Sakkinen
  2020-02-27  8:03 ` [PATCH v2] tpm: " Sergiu Cuciurean
  1 sibling, 0 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2020-02-26 15:12 UTC (permalink / raw)
  To: Sergiu Cuciurean
  Cc: gregkh, linux-integrity, linux-kernel, peterhuewe, jgg, arnd

On Wed, Feb 26, 2020 at 01:43:47PM +0200, Sergiu Cuciurean wrote:
> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current
> `delay_usecs` with `delay` for this driver.
> 
> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
> that both `delay_usecs` & `delay` are used (in this order to preserve
> backwards compatibility).
> 
> [1] commit bebcfd272df6 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")
> 
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>

In the short summary used "tpm:" instead of "Char:".

/Jarkko

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] tpm: tpm_tis_spi_cr50: use new structure for SPI transfer delays
  2020-02-26 11:43 [PATCH] Char: tpm_tis_spi_cr50: use new structure for SPI transfer delays Sergiu Cuciurean
  2020-02-26 15:12 ` Jarkko Sakkinen
@ 2020-02-27  8:03 ` Sergiu Cuciurean
  2020-02-27 16:22   ` Jarkko Sakkinen
  1 sibling, 1 reply; 4+ messages in thread
From: Sergiu Cuciurean @ 2020-02-27  8:03 UTC (permalink / raw)
  To: gregkh, linux-integrity, linux-kernel
  Cc: peterhuewe, jarkko.sakkinen, jgg, arnd, Sergiu Cuciurean

In a recent change to the SPI subsystem [1], a new `delay` struct was added
to replace the `delay_usecs`. This change replaces the current
`delay_usecs` with `delay` for this driver.

The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
that both `delay_usecs` & `delay` are used (in this order to preserve
backwards compatibility).

[1] commit bebcfd272df6 ("spi: introduce `delay` field for
`spi_transfer` + spi_transfer_delay_exec()")

Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
---

Changelog v1->v2:
*Change to proper subsystem prefix

 drivers/char/tpm/tpm_tis_spi_cr50.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_tis_spi_cr50.c b/drivers/char/tpm/tpm_tis_spi_cr50.c
index 37d72e818335..ea759af25634 100644
--- a/drivers/char/tpm/tpm_tis_spi_cr50.c
+++ b/drivers/char/tpm/tpm_tis_spi_cr50.c
@@ -132,7 +132,12 @@ static void cr50_wake_if_needed(struct cr50_spi_phy *cr50_phy)
 
 	if (cr50_needs_waking(cr50_phy)) {
 		/* Assert CS, wait 1 msec, deassert CS */
-		struct spi_transfer spi_cs_wake = { .delay_usecs = 1000 };
+		struct spi_transfer spi_cs_wake = {
+			.delay = {
+				.value = 1000,
+				.unit = SPI_DELAY_UNIT_USECS
+			}
+		};
 
 		spi_sync_transfer(phy->spi_device, &spi_cs_wake, 1);
 		/* Wait for it to fully wake */
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] tpm: tpm_tis_spi_cr50: use new structure for SPI transfer delays
  2020-02-27  8:03 ` [PATCH v2] tpm: " Sergiu Cuciurean
@ 2020-02-27 16:22   ` Jarkko Sakkinen
  0 siblings, 0 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2020-02-27 16:22 UTC (permalink / raw)
  To: Sergiu Cuciurean
  Cc: gregkh, linux-integrity, linux-kernel, peterhuewe, jgg, arnd

On Thu, Feb 27, 2020 at 10:03:39AM +0200, Sergiu Cuciurean wrote:
> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current
> `delay_usecs` with `delay` for this driver.
> 
> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
> that both `delay_usecs` & `delay` are used (in this order to preserve
> backwards compatibility).
> 
> [1] commit bebcfd272df6 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")
> 
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-02-27 16:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-26 11:43 [PATCH] Char: tpm_tis_spi_cr50: use new structure for SPI transfer delays Sergiu Cuciurean
2020-02-26 15:12 ` Jarkko Sakkinen
2020-02-27  8:03 ` [PATCH v2] tpm: " Sergiu Cuciurean
2020-02-27 16:22   ` Jarkko Sakkinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).