* [PATCH] backlight: sky81452: unsure while loop does not allow negative array indexing
@ 2020-02-26 19:57 Colin King
0 siblings, 0 replies; only message in thread
From: Colin King @ 2020-02-26 19:57 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han,
Bartlomiej Zolnierkiewicz, Gyungoh Yoo, Bryan Wu, dri-devel,
linux-fbdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
In the unlikely event that num_entry is zero, the while loop
pre-decrements num_entry to cause negative array indexing into the
array sources. Fix this by iterating only if num_entry >= 0.
Addresses-Coverity: ("Out-of-bounds read")
Fixes: f705806c9f35 ("backlight: Add support Skyworks SKY81452 backlight driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/video/backlight/sky81452-backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
index 2355f00f5773..f456930ce78e 100644
--- a/drivers/video/backlight/sky81452-backlight.c
+++ b/drivers/video/backlight/sky81452-backlight.c
@@ -200,7 +200,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
}
pdata->enable = 0;
- while (--num_entry)
+ while (--num_entry >= 0)
pdata->enable |= (1 << sources[num_entry]);
}
--
2.25.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-02-26 19:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-26 19:57 [PATCH] backlight: sky81452: unsure while loop does not allow negative array indexing Colin King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).