From: Stafford Horne <shorne@gmail.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Openrisc <openrisc@lists.librecores.org>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Christian Brauner <christian@brauner.io>
Subject: Re: [PATCH 2/3] openrisc: Enable the clone3 syscall
Date: Thu, 27 Feb 2020 22:29:08 +0900 [thread overview]
Message-ID: <20200227132908.GI7926@lianli.shorne-pla.net> (raw)
In-Reply-To: <20200227122147.rnpzcy7rjexgy6yx@wittgenstein>
On Thu, Feb 27, 2020 at 01:21:47PM +0100, Christian Brauner wrote:
> On Thu, Feb 27, 2020 at 07:56:24AM +0900, Stafford Horne wrote:
> > Enable the clone3 syscall for OpenRISC. We use the generic version.
> >
> > This was tested with the clone3 test from selftests. Note, for all
> > tests to pass it required enabling CONFIG_NAMESPACES which is not
> > enabled in the default kernel config.
>
> For OpenRISC, I assume. Hm, maybe we should fix the tests to skip when
> CONFIG_NAMESPACES is not enabled.
Yes, not the default for openrisc defconfig. It might make sense to either skip
the tests of have them as expected fails when CONFIG_NAMESPACES is off.
On the otherhand, I am not sure if the self tests know about the CONFIG_*
available. I notice many test directories have a 'config' file and a readme
saying, for these test to run ensure use have at least 'these' config values
set.
-Stafford
next prev parent reply other threads:[~2020-02-27 13:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 22:56 [PATCH 0/3] OpenRISC clone3 support Stafford Horne
2020-02-26 22:56 ` [PATCH 1/3] openrisc: Convert copy_thread to copy_thread_tls Stafford Horne
2020-02-27 0:31 ` Stafford Horne
2020-02-27 12:19 ` Christian Brauner
2020-02-27 13:16 ` Stafford Horne
2020-02-26 22:56 ` [PATCH 2/3] openrisc: Enable the clone3 syscall Stafford Horne
2020-02-27 12:21 ` Christian Brauner
2020-02-27 13:29 ` Stafford Horne [this message]
2020-02-26 22:56 ` [PATCH 3/3] openrisc: Cleanup copy_thread_tls docs and comments Stafford Horne
2020-02-27 12:24 ` Christian Brauner
2020-02-27 12:26 ` [PATCH 0/3] OpenRISC clone3 support Christian Brauner
2020-02-27 13:18 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227132908.GI7926@lianli.shorne-pla.net \
--to=shorne@gmail.com \
--cc=christian.brauner@ubuntu.com \
--cc=christian@brauner.io \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=openrisc@lists.librecores.org \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).