From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B678C3F35B for ; Thu, 27 Feb 2020 14:01:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DB8D20801 for ; Thu, 27 Feb 2020 14:01:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732861AbgB0OBG (ORCPT ); Thu, 27 Feb 2020 09:01:06 -0500 Received: from outbound-smtp14.blacknight.com ([46.22.139.231]:53101 "EHLO outbound-smtp14.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732636AbgB0OBD (ORCPT ); Thu, 27 Feb 2020 09:01:03 -0500 Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp14.blacknight.com (Postfix) with ESMTPS id 264941C3594 for ; Thu, 27 Feb 2020 14:01:00 +0000 (GMT) Received: (qmail 13599 invoked from network); 27 Feb 2020 14:00:59 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.18.57]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 27 Feb 2020 14:00:59 -0000 Date: Thu, 27 Feb 2020 14:00:57 +0000 From: Mel Gorman To: Lukasz Luba Cc: Valentin Schneider , linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com Subject: Re: [PATCH] sched/fair: Fix kernel build warning in test_idle_cores() for !SMT NUMA Message-ID: <20200227140057.GG3818@techsingularity.net> References: <20200227110053.2514-1-lukasz.luba@arm.com> <74d75844-e710-6df8-30a9-acd440394c2e@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <74d75844-e710-6df8-30a9-acd440394c2e@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 27, 2020 at 12:08:46PM +0000, Lukasz Luba wrote: > Hi Valentin, > > On 2/27/20 11:04 AM, Valentin Schneider wrote: > > Hi Lukasz, > > > > On 2/27/20 11:00 AM, Lukasz Luba wrote: > > > Fix kernel build warning in kernel/sched/fair.c when CONFIG_SCHED_SMT is > > > not set and CONFIG_NUMA_BALANCING is set. > > > > > > kernel/sched/fair.c:1524:20: warning: ???test_idle_cores??? declared ???static??? but never defined [-Wunused-function] > > > > > > > I've sent a similar fix yesterday at: > > > > https://lore.kernel.org/lkml/20200226121244.7524-1-valentin.schneider@arm.com/ > > > > I've missed it. You are referring in the commit message to wrong change > (probably HEAD of that branch), while when you try to bisect, it > will point you to > ff7db0bf24db sched/numa: Prefer using an idle CPU as a migration target > instead of comparing tasks > > I think Mel can simply resend the patches with correct build if Ingo > is OK. > > If Mel would decide to go with extended approach of ifdefs, then maybe > it's also good to put in there numa_idle_core(), which actually uses > these test_idle_cores() and is_core_idle() > I preferred the first fix. I'll send just it on with an editted changelog to identify the exact patch that caused the problem. Ingo will hopefully let me know if he prefers to pick up the fix on top or a resend of the series with the fix folded in. -- Mel Gorman SUSE Labs