From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14DBEC3F351 for ; Thu, 27 Feb 2020 14:33:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E818F24688 for ; Thu, 27 Feb 2020 14:33:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730132AbgB0Ods convert rfc822-to-8bit (ORCPT ); Thu, 27 Feb 2020 09:33:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:54244 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732522AbgB0OAG (ORCPT ); Thu, 27 Feb 2020 09:00:06 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0F330AD21; Thu, 27 Feb 2020 14:00:05 +0000 (UTC) Date: Thu, 27 Feb 2020 15:00:04 +0100 From: Thomas Bogendoerfer To: Pavel Machek Cc: Jacek Anaszewski , Dan Murphy , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v5] leds: add SGI IP30 led support Message-Id: <20200227150004.97154811ecbd2f5ccc22fa64@suse.de> In-Reply-To: <20200226140058.GH4080@duo.ucw.cz> References: <20200224111733.10320-1-tbogendoerfer@suse.de> <20200226140058.GH4080@duo.ucw.cz> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Feb 2020 15:00:58 +0100 Pavel Machek wrote: > > + switch (num) { > > + case IP30_LED_SYSTEM: > > + data->cdev.name = "white:system"; > > + break; > > + case IP30_LED_FAULT: > > + data->cdev.name = "red:fault"; > > + break; > > If the white LED normally serves as power indicator for the system, we > might want to specify that. Does it? it could be seen as such, but it will be turned on only after POST has finished successfull. So it's off if POST failed, which doesn't make it a real power led IMHO. Thomas. -- SUSE Software Solutions Germany GmbH HRB 36809 (AG Nürnberg) Geschäftsführer: Felix Imendörffer