From: Tony Lindgren <tony@atomide.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org,
Arthur Demchenkov <spinal.by@gmail.com>,
Merlijn Wajer <merlijn@wizzup.org>, Pavel Machek <pavel@ucw.cz>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH 2/2] Input: omap4-keypad - check state again for lost key-up interrupts
Date: Thu, 27 Feb 2020 08:08:20 -0800 [thread overview]
Message-ID: <20200227160820.GF37466@atomide.com> (raw)
In-Reply-To: <20200227020407.17276-2-tony@atomide.com>
* Tony Lindgren <tony@atomide.com> [200227 02:05]:
> + /* Check once after debounce time when no more keys down */
> + if (!new_keys_pressed) {
> + usleep_range(OMAP4_DEBOUNCE_MS * 1000 * 2,
> + OMAP4_DEBOUNCE_MS * 1000 * 3);
> + new_keys_pressed = omap4_keypad_scan_keys(keypad_data);
> + }
So this can be outside the loop. And we actually need to clear
the state looks like.
I'll send out v2 series of these after some more debugging.
Regards,
Tony
next prev parent reply other threads:[~2020-02-27 16:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 2:04 [PATCH 1/2] Input: omap4-keypad - Configure interrupt as level Tony Lindgren
2020-02-27 2:04 ` [PATCH 2/2] Input: omap4-keypad - check state again for lost key-up interrupts Tony Lindgren
2020-02-27 16:08 ` Tony Lindgren [this message]
2020-03-06 18:58 ` [PATCH 1/2] Input: omap4-keypad - Configure interrupt as level Dmitry Torokhov
2020-03-06 19:04 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227160820.GF37466@atomide.com \
--to=tony@atomide.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=spinal.by@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).