From: Rob Herring <robh@kernel.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/2] dt-bindings: net: Add ipq806x mdio bindings
Date: Thu, 27 Feb 2020 11:23:40 -0600 [thread overview]
Message-ID: <20200227172340.GA19136@bogus> (raw)
In-Reply-To: <20200227011050.11106-2-ansuelsmth@gmail.com>
On Thu, Feb 27, 2020 at 02:10:46AM +0100, Ansuel Smith wrote:
> Add documentations for ipq806x mdio driver.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> Changes in v8:
> - Fix error in dtb check
> - Remove not needed reset definition from example
> - Add include header for ipq806x clocks
> - Fix wrong License type
>
> Changes in v7:
> - Fix dt_binding_check problem
>
> .../bindings/net/qcom,ipq8064-mdio.yaml | 61 +++++++++++++++++++
> 1 file changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml
> new file mode 100644
> index 000000000000..4334a415f23c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: GPL-2.0-only
Dual license new bindings please:
(GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/qcom,ipq8064-mdio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm ipq806x MDIO bus controller
> +
> +maintainers:
> + - Ansuel Smith <ansuelsmth@gmail.com>
> +
> +description:
> + The ipq806x soc have a MDIO dedicated controller that is
> + used to comunicate with the gmac phy conntected.
2 typos
> + Child nodes of this MDIO bus controller node are standard
> + Ethernet PHY device nodes as described in
> + Documentation/devicetree/bindings/net/phy.txt
You might want to read what that file says now.
> +
> +allOf:
> + - $ref: "mdio.yaml#"
> +
> +properties:
> + compatible:
> + items:
> + - const: qcom,ipq8064-mdio
> + - const: syscon
Why is this a 'syscon'? Does it have more than 1 function?
> +
> + reg:
> + description: address and length of the register set for the device
Drop this and you need to state how many (maxItems).
> +
> + clocks:
> + description: A reference to the clock supplying the MDIO bus controller
Same here.
> +
> + clock-names:
> + const: master
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - "#address-cells"
> + - "#size-cells"
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,gcc-ipq806x.h>
> +
> + mdio0: mdio@37000000 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + compatible = "qcom,ipq8064-mdio", "syscon";
> + reg = <0x37000000 0x200000>;
> +
> + clocks = <&gcc GMAC_CORE1_CLK>;
> +
> + switch@10 {
> + compatible = "qca,qca8337";
> + /* ... */
> + };
> + };
> --
> 2.25.0
>
next prev parent reply other threads:[~2020-02-27 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 1:10 [PATCH v8 1/2] net: mdio: add ipq8064 mdio driver Ansuel Smith
2020-02-27 1:10 ` [PATCH v8 2/2] dt-bindings: net: Add ipq806x mdio bindings Ansuel Smith
2020-02-27 17:23 ` Rob Herring [this message]
2020-02-27 22:01 ` R: " ansuelsmth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227172340.GA19136@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).