From: Jordan Crouse <jcrouse@codeaurora.org>
To: iommu@lists.linux-foundation.org
Cc: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
AngeloGioacchino Del Regno <kholk11@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, Wen Yang <wen.yang99@zte.com.cn>,
will@kernel.org, Joerg Roedel <joro@8bytes.org>,
Ben Dooks <ben.dooks@codethink.co.uk>,
linux-arm-kernel@lists.infradead.org,
Wambui Karuga <wambui.karugax@gmail.com>,
freedreno@lists.freedesktop.org,
Fritz Koenig <frkoenig@google.com>,
linux-arm-msm@vger.kernel.org,
Sharat Masetty <smasetty@codeaurora.org>,
Jeykumar Sankaran <jsanka@codeaurora.org>,
Alexios Zavras <alexios.zavras@intel.com>,
Thomas Gleixner <tglx@linutronix.de>, Sean Paul <sean@poorly.run>,
Allison Randal <allison@lohutok.net>,
Enrico Weigelt <info@metux.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Douglas Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org, zhengbin <zhengbin13@huawei.com>,
Rob Clark <robdclark@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Drew Davenport <ddavenport@chromium.org>,
Brian Masney <masneyb@onstation.org>,
robin.murphy@arm.com, Georgi Djakov <georgi.djakov@linaro.org>
Subject: Re: [Freedreno] [PATCH v5 0/5] iommu/arm-smmu: Split pagetable support for arm-smmu-v2
Date: Thu, 27 Feb 2020 11:45:34 -0700 [thread overview]
Message-ID: <20200227184534.GA25772@jcrouse1-lnx.qualcomm.com> (raw)
In-Reply-To: <1580248819-12644-1-git-send-email-jcrouse@codeaurora.org>
On Tue, Jan 28, 2020 at 03:00:14PM -0700, Jordan Crouse wrote:
> This is another iteration for the split pagetable support based on the
> suggestions from Robin and Will [1].
>
> Background: In order to support per-context pagetables the GPU needs to enable
> split tables so that we can store global buffers in the TTBR1 space leaving the
> GPU free to program the TTBR0 register with the address of a context specific
> pagetable.
>
> If the DOMAIN_ATTR_SPLIT_TABLES attribute is set on the domain before attaching,
> the context bank assigned to the domain will be programmed to allow translations
> in the TTBR1 space. Translations in the TTBR0 region will be disallowed because,
> as Robin pointe out, having a un-programmed TTBR0 register is dangerous.
>
> The driver can determine if TTBR1 was successfully programmed by querying
> DOMAIN_ATTR_SPLIT_TABLES after attaching. The domain geometry will also be
> updated to reflect the virtual address space for the TTBR1 range.
>
> Upcoming changes will allow auxiliary domains to be attached to the device which
> will enable and program TTBR0.
>
> This patchset is based on top of linux-next-20200127.
Quick ping for feedback so I can respin for (maybe?) 5.6.
Thanks,
Jordan
> Change log:
>
> v4: Only program TTBR1 when split pagetables are requested. TTBR0 will be
> enabled later when an auxiliary domain is attached
> v3: Remove the implementation specific and make split pagetable support
> part of the generic configuration
>
> [1] https://lists.linuxfoundation.org/pipermail/iommu/2020-January/041373.html
>
> Jordan Crouse (5):
> iommu: Add DOMAIN_ATTR_SPLIT_TABLES
> iommu/arm-smmu: Add support for TTBR1
> drm/msm: Attach the IOMMU device during initialization
> drm/msm: Refactor address space initialization
> drm/msm/a6xx: Support split pagetables
>
> drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 16 ++++++++++
> drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 1 +
> drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 1 +
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 1 +
> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 51 ++++++++++++++++++++++++++++++++
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 23 ++++++++++----
> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 8 +++++
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 ++++-------
> drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 18 +++++------
> drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 4 ---
> drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 18 +++++------
> drivers/gpu/drm/msm/msm_drv.h | 8 ++---
> drivers/gpu/drm/msm/msm_gem_vma.c | 36 ++++------------------
> drivers/gpu/drm/msm/msm_gpu.c | 49 ++----------------------------
> drivers/gpu/drm/msm/msm_gpu.h | 4 +--
> drivers/gpu/drm/msm/msm_gpummu.c | 6 ----
> drivers/gpu/drm/msm/msm_iommu.c | 18 ++++++-----
> drivers/gpu/drm/msm/msm_mmu.h | 1 -
> drivers/iommu/arm-smmu.c | 48 +++++++++++++++++++++++++-----
> drivers/iommu/arm-smmu.h | 22 ++++++++++----
> include/linux/iommu.h | 2 ++
> 21 files changed, 198 insertions(+), 155 deletions(-)
>
> --
> 2.7.4
> _______________________________________________
> Freedreno mailing list
> Freedreno@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/freedreno
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2020-02-27 18:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 22:00 [PATCH v5 0/5] iommu/arm-smmu: Split pagetable support for arm-smmu-v2 Jordan Crouse
2020-01-28 22:00 ` [PATCH v5 1/5] iommu: Add DOMAIN_ATTR_SPLIT_TABLES Jordan Crouse
2020-01-28 22:00 ` [PATCH v5 2/5] iommu/arm-smmu: Add support for TTBR1 Jordan Crouse
2020-03-18 22:34 ` Will Deacon
2020-01-28 22:00 ` [PATCH v5 3/5] drm/msm: Attach the IOMMU device during initialization Jordan Crouse
2020-01-28 22:00 ` [PATCH v5 4/5] drm/msm: Refactor address space initialization Jordan Crouse
2020-01-28 22:00 ` [PATCH v5 5/5] drm/msm/a6xx: Support split pagetables Jordan Crouse
2020-02-27 18:45 ` Jordan Crouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227184534.GA25772@jcrouse1-lnx.qualcomm.com \
--to=jcrouse@codeaurora.org \
--cc=airlied@linux.ie \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=ben.dooks@codethink.co.uk \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=ddavenport@chromium.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=frkoenig@google.com \
--cc=georgi.djakov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=iommu@lists.linux-foundation.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=joro@8bytes.org \
--cc=jsanka@codeaurora.org \
--cc=kholk11@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=smasetty@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=wambui.karugax@gmail.com \
--cc=wen.yang99@zte.com.cn \
--cc=will@kernel.org \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).