From: Vijay Thakkar <vijaythakkar@me.com>
To: Kim Phillips <kim.phillips@amd.com>
Cc: "Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"Martin Liška" <mliska@suse.cz>, "Jon Grimm" <jon.grimm@amd.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 3/3] perf vendor events amd: update Zen1 events to V2
Date: Thu, 27 Feb 2020 15:00:26 -0500 [thread overview]
Message-ID: <20200227200026.GA8493@shwetrath.localdomain> (raw)
In-Reply-To: <73b5b731-9597-1243-485a-788437500c7a@amd.com>
> OSRR for AMD Family 17h processors, Models 00h-2Fh, 56255 Rev 3.03 - July, 2018
I have included this for v3 that I will submit later, including all the
changes for the FPU counters. Sorry, I messed up copy-pasting the text
and forgot to change the trailing pipe number.
> and their counts don't seem to match up very well when running
> various workloads. The microarchitecture is likely to have changed
> in this area from families prior to 17h, so a MAB alloc can likely
> count different events than what is presumed here: a Data cache
> load/store/prefetch miss.
>
> I think it's safer to just leave the PPR text "LS MAB Allocates
> by Type" as-is, instead of assuming they are L1 load/store misses.
> What do you think?
I did some checking accross PPRs, and this counter seems to have changed
names multiple times throughout the PPR revisions.
Zen1 PPR (54945 Rev 1.14 - April 15, 2017) lists counter called "LsMabAllocPipe"
with 5 subcounters that have different names compared to ones we see in
the mainline right now. PPRs for stepping B2
onwards change this to the 3 sub-counter and primary counter name
we see right now. This public description still changes accross various
PPR revisions, which is why I had this set to what it was. The lastest
PPR I can find is indeed lists it as "LS MAB Allocates by Type";
I will change it to that with the fuffix of tehe sub-counter name. Since
the same counter is in Zen2 as well, I will make the same changes there
too.
Let me know if this sounds good to you!
Best,
Vijay
next prev parent reply other threads:[~2020-02-27 20:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 19:28 [PATCH v2 0/3] latest PMU events for zen1/zen2 Vijay Thakkar
2020-02-25 19:28 ` [PATCH v2 1/3] perf vendor events amd: restrict model detection for zen1 based processors Vijay Thakkar
2020-02-25 19:28 ` [PATCH v2 2/3] perf vendor events amd: add Zen2 events Vijay Thakkar
2020-02-26 22:09 ` Kim Phillips
2020-02-28 16:00 ` Vijay Thakkar
2020-02-28 16:24 ` Kim Phillips
2020-02-28 17:27 ` Vijay Thakkar
2020-02-28 17:34 ` Vijay Thakkar
2020-02-25 19:28 ` [PATCH v2 3/3] perf vendor events amd: update Zen1 events to V2 Vijay Thakkar
2020-02-25 22:53 ` Kim Phillips
2020-02-27 20:00 ` Vijay Thakkar [this message]
2020-02-27 21:20 ` Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227200026.GA8493@shwetrath.localdomain \
--to=vijaythakkar@me.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=jon.grimm@amd.com \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mliska@suse.cz \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).