From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Siddharth Gupta <sidgup@codeaurora.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org, ohad@wizery.com,
Rishabh Bhatnagar <rishabhb@codeaurora.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, tsoni@codeaurora.org,
psodagud@codeaurora.org
Subject: Re: [PATCH 4/6] drivers: remoteproc: Add name field for every subdevice
Date: Thu, 27 Feb 2020 13:14:08 -0700 [thread overview]
Message-ID: <20200227201408.GB20116@xps15> (raw)
In-Reply-To: <1582167465-2549-5-git-send-email-sidgup@codeaurora.org>
On Wed, Feb 19, 2020 at 06:57:43PM -0800, Siddharth Gupta wrote:
> From: Rishabh Bhatnagar <rishabhb@codeaurora.org>
>
> When a client driver wishes to utilize functionality from a particular
> subdevice of a remoteproc, it cannot differentiate between the subdevices
> that have been added. This patch allows the client driver to distinguish
> between subdevices and thus utilize their functionality.
>
> Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
> Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
> ---
> drivers/remoteproc/qcom_common.c | 6 ++++++
> include/linux/remoteproc.h | 2 ++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c
> index 60650bc..5d59538 100644
> --- a/drivers/remoteproc/qcom_common.c
> +++ b/drivers/remoteproc/qcom_common.c
> @@ -58,6 +58,7 @@ void qcom_add_glink_subdev(struct rproc *rproc, struct qcom_rproc_glink *glink)
> glink->dev = dev;
> glink->subdev.start = glink_subdev_start;
> glink->subdev.stop = glink_subdev_stop;
> + glink->subdev.name = kstrdup("glink", GFP_KERNEL);
Because @subdev is a member of qcom_rproc_glink (rather than a pointer), it is
possible to get to glink with container_of(). From there edge->name is
available - would that work?
>
> rproc_add_subdev(rproc, &glink->subdev);
> }
> @@ -73,6 +74,7 @@ void qcom_remove_glink_subdev(struct rproc *rproc, struct qcom_rproc_glink *glin
> if (!glink->node)
> return;
>
> + kfree(glink->subdev.name);
> rproc_remove_subdev(rproc, &glink->subdev);
> of_node_put(glink->node);
> }
> @@ -154,6 +156,7 @@ void qcom_add_smd_subdev(struct rproc *rproc, struct qcom_rproc_subdev *smd)
> smd->dev = dev;
> smd->subdev.start = smd_subdev_start;
> smd->subdev.stop = smd_subdev_stop;
> + smd->subdev.name = kstrdup("smd", GFP_KERNEL);
Same as above - qcom_smd_edge has a name.
Worse case scenario, both qcom_rproc_glink and qcom_smd_edge have a device_node
that can be used as well.
>
> rproc_add_subdev(rproc, &smd->subdev);
> }
> @@ -169,6 +172,7 @@ void qcom_remove_smd_subdev(struct rproc *rproc, struct qcom_rproc_subdev *smd)
> if (!smd->node)
> return;
>
> + kfree(smd->subdev.name);
> rproc_remove_subdev(rproc, &smd->subdev);
> of_node_put(smd->node);
> }
> @@ -220,6 +224,7 @@ void qcom_add_ssr_subdev(struct rproc *rproc, struct qcom_rproc_ssr *ssr,
> const char *ssr_name)
> {
> ssr->name = ssr_name;
> + ssr->subdev.name = kstrdup("ssr_notifs", GFP_KERNEL);
> ssr->subdev.unprepare = ssr_notify_unprepare;
>
> rproc_add_subdev(rproc, &ssr->subdev);
> @@ -233,6 +238,7 @@ EXPORT_SYMBOL_GPL(qcom_add_ssr_subdev);
> */
> void qcom_remove_ssr_subdev(struct rproc *rproc, struct qcom_rproc_ssr *ssr)
> {
> + kfree(ssr->subdev.name);
> rproc_remove_subdev(rproc, &ssr->subdev);
> }
> EXPORT_SYMBOL_GPL(qcom_remove_ssr_subdev);
> diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
> index e2eaba9..e2f60cc 100644
> --- a/include/linux/remoteproc.h
> +++ b/include/linux/remoteproc.h
> @@ -519,6 +519,7 @@ struct rproc {
> /**
> * struct rproc_subdev - subdevice tied to a remoteproc
> * @node: list node related to the rproc subdevs list
> + * @name: name of the subdevice
> * @prepare: prepare function, called before the rproc is started
> * @start: start function, called after the rproc has been started
> * @stop: stop function, called before the rproc is stopped; the @crashed
> @@ -527,6 +528,7 @@ struct rproc {
> */
> struct rproc_subdev {
> struct list_head node;
> + char *name;
>
> int (*prepare)(struct rproc_subdev *subdev);
> int (*start)(struct rproc_subdev *subdev);
> --
> Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-02-27 20:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 2:57 [PATCH 0/6] remoteproc: qcom: Add callbacks for remoteproc events Siddharth Gupta
2020-02-20 2:57 ` [PATCH 1/6] remoteproc: sysmon: Add ability to send type of notification Siddharth Gupta
2020-02-20 2:57 ` [PATCH 2/6] remoteproc: sysmon: Add notifications for events Siddharth Gupta
2020-02-20 2:57 ` [PATCH 3/6] remoteproc: sysmon: Inform current rproc about all active rprocs Siddharth Gupta
2020-02-27 18:47 ` Mathieu Poirier
2020-02-20 2:57 ` [PATCH 4/6] drivers: remoteproc: Add name field for every subdevice Siddharth Gupta
2020-02-27 20:14 ` Mathieu Poirier [this message]
2020-02-20 2:57 ` [PATCH 5/6] remoteproc: qcom: Add per subsystem SSR notification Siddharth Gupta
2020-02-20 2:57 ` [PATCH 6/6] remoteproc: qcom: Add notification types to SSR Siddharth Gupta
2020-02-27 21:59 ` Mathieu Poirier
2020-02-28 0:00 ` rishabhb
2020-02-28 18:38 ` Mathieu Poirier
2020-03-02 20:54 ` rishabhb
2020-03-03 18:05 ` Mathieu Poirier
2020-03-03 23:30 ` rishabhb
2020-03-09 17:34 ` Mathieu Poirier
2020-04-02 1:01 ` Siddharth Gupta
2020-04-02 17:47 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227201408.GB20116@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=psodagud@codeaurora.org \
--cc=rishabhb@codeaurora.org \
--cc=sidgup@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).