From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Maulik Shah <mkshah@codeaurora.org>
Cc: swboyd@chromium.org, mka@chromium.org, evgreen@chromium.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
agross@kernel.org, dianders@chromium.org, rnayak@codeaurora.org,
ilina@codeaurora.org, lsrao@codeaurora.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: sc7180: Enable soc sleep stats
Date: Thu, 27 Feb 2020 22:34:44 -0800 [thread overview]
Message-ID: <20200228063444.GA857139@builder> (raw)
In-Reply-To: <1582274986-17490-4-git-send-email-mkshah@codeaurora.org>
On Fri 21 Feb 00:49 PST 2020, Maulik Shah wrote:
> SoC sleep stats provides various low power mode stats.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 8011c5f..eee6d92 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -745,6 +745,11 @@
> };
> };
>
> + rpmh_sleep_stats: soc-sleep-stats@c3f0000 {
I don't see any reason to reference this node, so you should be able to
omit the label(?)
> + compatible = "qcom,rpmh-sleep-stats";
> + reg = <0 0xc3f0000 0 0x400>;
Please pad the address to 8 digits and sort the nodes by address.
Regards,
Bjorn
> + };
> +
> tcsr_mutex_regs: syscon@1f40000 {
> compatible = "syscon";
> reg = <0 0x01f40000 0 0x40000>;
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2020-02-28 6:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 8:49 [PATCH v2 0/4] Introduce SoC sleep stats driver Maulik Shah
2020-02-21 8:49 ` [PATCH v2 1/4] dt-bindings: Introduce soc sleep stats bindings for Qualcomm SoCs Maulik Shah
2020-02-26 20:05 ` Rob Herring
2020-02-28 6:38 ` Bjorn Andersson
2020-02-28 16:47 ` Stephen Boyd
2020-03-06 6:22 ` Maulik Shah
2020-02-21 8:49 ` [PATCH v2 2/4] soc: qcom: Add SoC sleep stats driver Maulik Shah
2020-02-28 21:10 ` Stephen Boyd
2020-03-06 6:35 ` Maulik Shah
2020-02-21 8:49 ` [PATCH v2 3/4] arm64: dts: qcom: sc7180: Enable soc sleep stats Maulik Shah
2020-02-28 6:34 ` Bjorn Andersson [this message]
2020-03-03 7:09 ` Maulik Shah
2020-02-21 8:49 ` [PATCH v2 4/4] arm64: defconfig: Enable SoC sleep stats driver for Qualcomm Maulik Shah
2020-02-28 6:37 ` Bjorn Andersson
2020-03-03 7:08 ` Maulik Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228063444.GA857139@builder \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsrao@codeaurora.org \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).