From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E63BC3F2D1 for ; Fri, 28 Feb 2020 10:46:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E1C824697 for ; Fri, 28 Feb 2020 10:46:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LhmwIPdr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726894AbgB1KqN (ORCPT ); Fri, 28 Feb 2020 05:46:13 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:43579 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726063AbgB1KqM (ORCPT ); Fri, 28 Feb 2020 05:46:12 -0500 Received: by mail-wr1-f65.google.com with SMTP id e10so957037wrr.10 for ; Fri, 28 Feb 2020 02:46:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WroTn4ZOSoWOI3ov0YWSSJUWyAnuK2wVB2xk4MqHAcc=; b=LhmwIPdrdZKpLzy/06ivR114pWiTD8AkY4r+Z8gIpWanabMMYs66F+chnVJMHYAj2p EQdsRe7kxLBGiAG1Op/O0O/A1PcZoPdG4+Q/B4VPKPeZFD02wX1hp4csQC0coTSa8o2A D5zO5vvFeWHlvpJlsDQowCEuMhPx/T7pSSOFLH5goxsoFvm/DqN70t02JJ9FC+szfOjo oM1C9CC5bwOmmGwhyQUibA6FSh2SUK+QMCqmdGmFDcidAJMUZXXiHCwuJa8+qW0IwRDj HbBhVHc8HLNKucYRpT3uexbCfzvpBjxySZlVYqMS4+YxeBDKcSOaY0pAPM5FXzDfuhPg NyHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WroTn4ZOSoWOI3ov0YWSSJUWyAnuK2wVB2xk4MqHAcc=; b=akV03dACYluX4/uMLHgit2ATz/bl3q9uS1nB47iJmD2WduLPw0QT5rpxkBeYsEhPHz Kq82UMKTM/88/ZLMzrKjb+kgskodq7Me1HOQW6xsUTgRxFSCKZltytq9POnfXwT7yblB IO8ge/a+trhU5J09W6627pGWe5D0JIbMpmVO8dJ8tyOvM13/pzL/ZL68RZo7yKVF2QGA VUfUWDiSmIzhDjegFhhUwEzDUtZNqeNj1vVma2qrO+WCOJznZBgolKC/DNS1QtHoVLxh AllGCdRQbSKs88wlhdyPidAbvUerbZZ1AXhDqtwZzvoFIIK9FGAXR3w73cbv4V0YQSmS d9+w== X-Gm-Message-State: APjAAAUOQ0/axzdLfuvRp97Da0Wrk4FK0kQe+MBq66pI02H9opNnbILY MuZ5couNpAXuhzqs3FCreG9vYXjhEOk= X-Google-Smtp-Source: APXvYqwJOE0fqXlVeja/r5Fj91sS1NrDnRD2e4QVZWt0hqhAnh6s1ILszXX+lUHYng+CHur/FGDR2A== X-Received: by 2002:adf:fe83:: with SMTP id l3mr4471825wrr.41.1582886770366; Fri, 28 Feb 2020 02:46:10 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id i4sm1610787wmd.23.2020.02.28.02.46.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 02:46:09 -0800 (PST) Date: Fri, 28 Feb 2020 10:46:06 +0000 From: Quentin Perret To: Masahiro Yamada Cc: Nicolas Pitre , Linux Kernel Mailing List , Linux Kbuild mailing list , Matthias Maennich , "Cc: Android Kernel" , Jessica Yu , Christoph Hellwig Subject: Re: [PATCH v5 3/3] kbuild: generate autoksyms.h early Message-ID: <20200228104606.GA139632@google.com> References: <20200218094139.78835-1-qperret@google.com> <20200218094139.78835-4-qperret@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 28 Feb 2020 at 19:42:41 (+0900), Masahiro Yamada wrote: > On Tue, Feb 18, 2020 at 6:41 PM Quentin Perret wrote: > > > > When doing a cold build, autoksyms.h starts empty, and is updated late > > in the build process to have visibility over the symbols used by in-tree > > drivers. But since the symbol whitelist is known upfront, it can be used > > to pre-populate autoksyms.h and maximize the amount of code that can be > > compiled to its final state in a single pass, hence reducing build time. > > > > Do this by using gen_autoksyms.sh to initialize autoksyms.h instead of > > creating an empty file. > > > > Acked-by: Nicolas Pitre > > Tested-by: Matthias Maennich > > Reviewed-by: Matthias Maennich > > Signed-off-by: Quentin Perret > > --- > > Makefile | 7 +++++-- > > scripts/gen_autoksyms.sh | 3 ++- > > 2 files changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index 84b71845c43f..17b7e7f441bd 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -1062,9 +1062,12 @@ endif > > > > autoksyms_h := $(if $(CONFIG_TRIM_UNUSED_KSYMS), include/generated/autoksyms.h) > > > > +quiet_cmd_autoksyms_h = GEN $@ > > + cmd_autoksyms_h = mkdir -p $(dir $@); $(CONFIG_SHELL) \ > > + $(srctree)/scripts/gen_autoksyms.sh $@ > > > When you send v6, > could you wrap the line as follows (CONFIG_SHELL in the next line) ? > > cmd_autoksyms_h = mkdir -p $(dir $@); \ > $(CONFIG_SHELL) $(srctree)/scripts/gen_autoksyms.sh $@ > > > This still fits in 80-cols. Will do. Thanks, Quentin