From: Luis Chamberlain <mcgrof@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] lib/test_kmod: remove a NULL test
Date: Fri, 28 Feb 2020 13:04:44 +0000 [thread overview]
Message-ID: <20200228130444.GY11244@42.do-not-panic.com> (raw)
In-Reply-To: <20200228092452.vwkhthsn77nrxdy6@kili.mountain>
On Fri, Feb 28, 2020 at 12:24:52PM +0300, Dan Carpenter wrote:
> The "info" pointer has already been dereferenced so checking here is
> too late. Fortunately, we never pass NULL pointers to the
> test_kmod_put_module() function so the test can simply be removed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Andrew, mind this going up through you? I'll bounce you the original
next.
Luis
> ---
> lib/test_kmod.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/test_kmod.c b/lib/test_kmod.c
> index 9cf77628fc91..e651c37d56db 100644
> --- a/lib/test_kmod.c
> +++ b/lib/test_kmod.c
> @@ -204,7 +204,7 @@ static void test_kmod_put_module(struct kmod_test_device_info *info)
> case TEST_KMOD_DRIVER:
> break;
> case TEST_KMOD_FS_TYPE:
> - if (info && info->fs_sync && info->fs_sync->owner)
> + if (info->fs_sync && info->fs_sync->owner)
> module_put(info->fs_sync->owner);
> break;
> default:
> --
> 2.11.0
>
prev parent reply other threads:[~2020-02-28 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 9:24 [PATCH] lib/test_kmod: remove a NULL test Dan Carpenter
2020-02-28 13:04 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228130444.GY11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).