From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4A16C3F2CD for ; Fri, 28 Feb 2020 13:35:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A0FF2469D for ; Fri, 28 Feb 2020 13:35:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="YVBzc0fP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726906AbgB1NfC (ORCPT ); Fri, 28 Feb 2020 08:35:02 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:39266 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726758AbgB1NfC (ORCPT ); Fri, 28 Feb 2020 08:35:02 -0500 Received: by mail-qt1-f195.google.com with SMTP id p34so1988042qtb.6 for ; Fri, 28 Feb 2020 05:35:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SO4k+cEae+kcaRUxuLpklhk4ez8pzokBlgA+/XnFpzY=; b=YVBzc0fPtfTWU3WI4CpD6wflzlKNfGdtBy6xeStvbbJrgzA1/3+LYWWJJUKFHLlNe6 estvGTicQLamm11cs7CeJACAaxInS7RYp50Ztlq8H6enN1ap/uDBCZGrp01GO+iJRfIo f9AQLO3nan12oFT4cROZv+gFhJRYiiUvK/NiN1xOGXaQVrAU3sF5LpTxKxD41jmRvNf8 PaL+thoLLUdzf38op6Q1/pE7SJNflTxQSjoshQsa2XyYGSpX/1fVU/9woELTNFVBP8L6 j4p3BrvBSXmHOMVMeKrnH+22GmcJSgmom5xUSelUdQBcdQiwVibPhsEnqQPTwhfKHlje 6KdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SO4k+cEae+kcaRUxuLpklhk4ez8pzokBlgA+/XnFpzY=; b=uNejXHyto6rrKsECJ4VFx/VF7LUcQQC6IQzpt6jszSQwarSK5bW1lDu7EW5OOJxytO PW+DTeLjfd4L0/h1n74Swurjy5gxtkIZ4anWBSG2Qq0Y05nxUiA+EMZ/Q8eiXiWTO7hO SlL3YIt5XpU/NxifcU/WeCGDaO5Iw2Io6sCJcp6sW0wA7yhsMJD17CDzwABlDMBSQPDf 8YPVDT392uWvlp4PQg0a+81wUPyhJDHoIfq98SNia3GibjfyahVD7lUTWlj6g/hrBr9J yyqbgdTKs8ujy8qlaq04y1m9K9qyJkVjHX6zWvsrjBiIBRuBerQEtNNU6KfMjJIcXyOC 9dZg== X-Gm-Message-State: APjAAAWf8wDJUsZ/Zx0ydNnbLrbf+mIcSO56b6B8Ty4ss7bz+a0sdFsa 6n+bRL/rXkh9doldhyiaJ6sR0w== X-Google-Smtp-Source: APXvYqz34jQPrszufJ93Ceni4PEZYOnNx21NiUQdDnBqKX3jqVT7UroWcBUFS7T8hVPeCfHcAR4H6g== X-Received: by 2002:ac8:5190:: with SMTP id c16mr4174211qtn.200.1582896901187; Fri, 28 Feb 2020 05:35:01 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id o25sm5120118qkk.7.2020.02.28.05.35.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Feb 2020 05:35:00 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1j7fnA-0007ph-1Q; Fri, 28 Feb 2020 09:35:00 -0400 Date: Fri, 28 Feb 2020 09:35:00 -0400 From: Jason Gunthorpe To: Bernard Metzler Cc: syzbot , chuck.lever@oracle.com, dledford@redhat.com, leon@kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, parav@mellanox.com, syzkaller-bugs@googlegroups.com, willy@infradead.org Subject: Re: Re: possible deadlock in cma_netdev_callback Message-ID: <20200228133500.GN31668@ziepe.ca> References: <20200227164622.GJ31668@ziepe.ca> <20200227155335.GI31668@ziepe.ca> <20200226204238.GC31668@ziepe.ca> <000000000000153fac059f740693@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 28, 2020 at 01:05:53PM +0000, Bernard Metzler wrote: > > >To: "Bernard Metzler" > >From: "Jason Gunthorpe" > >Date: 02/27/2020 05:46PM > >Cc: "syzbot" , > >chuck.lever@oracle.com, dledford@redhat.com, leon@kernel.org, > >linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, > >netdev@vger.kernel.org, parav@mellanox.com, > >syzkaller-bugs@googlegroups.com, willy@infradead.org > >Subject: [EXTERNAL] Re: possible deadlock in cma_netdev_callback > > > >On Thu, Feb 27, 2020 at 04:21:21PM +0000, Bernard Metzler wrote: > >> > >> >To: "Bernard Metzler" > >> >From: "Jason Gunthorpe" > >> >Date: 02/27/2020 04:53PM > >> >Cc: "syzbot" > >, > >> >chuck.lever@oracle.com, dledford@redhat.com, leon@kernel.org, > >> >linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, > >> >netdev@vger.kernel.org, parav@mellanox.com, > >> >syzkaller-bugs@googlegroups.com, willy@infradead.org > >> >Subject: [EXTERNAL] Re: possible deadlock in cma_netdev_callback > >> > > >> >On Thu, Feb 27, 2020 at 10:11:13AM +0000, Bernard Metzler wrote: > >> > > >> >> Thanks for letting me know! Hmm, we cannot use RCU locks since > >> >> we potentially sleep. One solution would be to create a list > >> >> of matching interfaces while under lock, unlock and use that > >> >> list for calling siw_listen_address() (which may sleep), > >> >> right...? > >> > > >> >Why do you need to iterate over addresses anyhow? Shouldn't the > >> >listen > >> >just be done with the address the user gave and a BIND DEVICE to > >the > >> >device siw is connected to? > >> > >> The user may give a wildcard local address, so we'd have > >> to bind to all addresses of that device... > > > >AFAIK a wild card bind using BIND DEVICE works just fine? > > > >Jason > > > Thanks Jason, absolutely! And it makes things so easy... Probably check to confirm, it just my memory.. Jason