From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Borislav Petkov <bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Leo Yan <leo.yan@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 03/13] kprobes: Add symbols for kprobe insn pages
Date: Fri, 28 Feb 2020 15:51:43 -0300 [thread overview]
Message-ID: <20200228185143.GA2904@kernel.org> (raw)
In-Reply-To: <20200228172004.GI5451@krava>
Em Fri, Feb 28, 2020 at 06:20:04PM +0100, Jiri Olsa escreveu:
> On Fri, Feb 28, 2020 at 11:36:00PM +0900, Masami Hiramatsu wrote:
> > On Fri, 28 Feb 2020 15:51:15 +0200
> > Adrian Hunter <adrian.hunter@intel.com> wrote:
> > > # perf probe __schedule
> > > Added new event:
> > > probe:__schedule (on __schedule)
> > > # cat /proc/kallsyms | grep '\[kprobe\]'
> > > ffffffffc0035000 t kprobe_insn_page [kprobe]
> > > ffffffffc0054000 t kprobe_optinsn_page [kprobe]
> > Could you make the module name as [kprobes] ?
> > BTW, it seems to pretend to be a module, but is there no concern of
> > confusing users? Shouldn't it be [*kprobes] so that it is non-exist
> > module name?
> note we already have bpf symbols as [bpf] module
That bracket-wrapped convention by now is not module related, but
instead non-main-kernel :-) If one wants to enumerate the modules in the
system, then use /proc/modules, then, to get the symbols for it, look at
symbols in /proc/kallsyms in that [ start, start + module size ] range
and strip whatever comes after '[' :-)
- Arnaldo
next prev parent reply other threads:[~2020-02-28 18:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 13:51 [PATCH V3 00/13] perf/x86: Add perf text poke events Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 01/13] perf: Add perf text poke event Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 02/13] perf/x86: Add support for perf text poke event for text_poke_bp_batch() callers Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 03/13] kprobes: Add symbols for kprobe insn pages Adrian Hunter
2020-02-28 14:36 ` Masami Hiramatsu
2020-02-28 17:20 ` Jiri Olsa
2020-02-28 18:51 ` Arnaldo Carvalho de Melo [this message]
2020-02-29 4:49 ` Masami Hiramatsu
2020-02-29 23:49 ` Steven Rostedt
2020-03-02 14:43 ` Jiri Olsa
2020-03-03 10:47 ` [OT] Pseudo module name in kallsyms (Re: [PATCH V3 03/13] kprobes: Add symbols for kprobe insn pages) Masami Hiramatsu
2020-03-03 10:55 ` Adrian Hunter
2020-03-03 14:21 ` Steven Rostedt
2020-03-03 15:40 ` Masami Hiramatsu
2020-02-28 13:51 ` [PATCH V3 04/13] kprobes: Add perf ksymbol events for kprobe insn pages Adrian Hunter
2020-02-28 15:11 ` Masami Hiramatsu
2020-02-29 3:51 ` Masami Hiramatsu
2020-02-28 13:51 ` [PATCH V3 05/13] perf/x86: Add perf text poke events for kprobes Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 06/13] ftrace: Add symbols for ftrace trampolines Adrian Hunter
2020-02-28 16:27 ` Steven Rostedt
2020-02-28 13:51 ` [PATCH V3 07/13] ftrace: Add perf ksymbol events " Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 08/13] ftrace: Add perf text poke " Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 09/13] perf kcore_copy: Fix module map when there are no modules loaded Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 10/13] perf evlist: Disable 'immediate' events last Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 11/13] perf tools: Add support for PERF_RECORD_TEXT_POKE Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 12/13] perf tools: Add support for PERF_RECORD_KSYMBOL_TYPE_OOL Adrian Hunter
2020-02-28 13:51 ` [PATCH V3 13/13] perf intel-pt: Add support for text poke events Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228185143.GA2904@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).