From: Steven Rostedt <rostedt@goodmis.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] trace: Export anonymous tracing
Date: Sun, 1 Mar 2020 13:18:16 -0500 [thread overview]
Message-ID: <20200301131816.277dd398@oasis.local.home> (raw)
In-Reply-To: <20200301155248.4132645-1-chris@chris-wilson.co.uk>
On Sun, 1 Mar 2020 15:52:47 +0000
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> To facilitate construction of per-client event ringbuffers, in
> particular for a per-client debug and error report log, it would be
> extremely useful to create an anonymous file that can be handed to
> userspace so that it can see its and only its events. trace already
> provides a means of encapsulating the trace ringbuffer into a struct
> file that can be opened via the tracefs, and so with a couple of minor
> tweaks can provide the same access via an anonymous inode.
I'm curious to why we need it to be anonymous. Why not allow them to be
visible from the tracing directory. This could allow for easier
debugging. Note, the trace instances have ref counters thus they can't
be removed if something has a reference to it.
Also, all the global functions require kernel doc comments to explain
how they work and what they are for.
-- Steve
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
> include/linux/trace.h | 4 ++
> kernel/trace/trace.c | 142 ++++++++++++++++++++++++++++++------------
> 2 files changed, 105 insertions(+), 41 deletions(-)
>
next prev parent reply other threads:[~2020-03-01 18:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 15:52 [PATCH 1/2] trace: Export anonymous tracing Chris Wilson
2020-03-01 15:52 ` [PATCH 2/2] RFC drm/i915: Export per-client debug tracing Chris Wilson
2020-03-01 16:27 ` [Intel-gfx] " Lionel Landwerlin
2020-03-01 16:33 ` Chris Wilson
2020-03-02 12:06 ` Daniel Vetter
2020-03-01 18:18 ` Steven Rostedt [this message]
2020-03-01 22:22 ` [PATCH 1/2] trace: Export anonymous tracing Chris Wilson
2020-03-02 0:36 ` Steven Rostedt
2020-03-03 23:24 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200301131816.277dd398@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).