From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: a.hajda@samsung.com, narmstrong@baylibre.com, jonas@kwiboo.se,
airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] drm/bridge: dw-hdmi: fix AVI frame colorimetry
Date: Mon, 2 Mar 2020 11:21:24 +0200 [thread overview]
Message-ID: <20200302092124.GD11960@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200229163043.158262-2-jernej.skrabec@siol.net>
Hi Jernej,
Thank you for the patch.
On Sat, Feb 29, 2020 at 05:30:40PM +0100, Jernej Skrabec wrote:
> CTA-861-F explicitly states that for RGB colorspace colorimetry should
> be set to "none". Fix that.
>
> Fixes: def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 46 +++++++++++++----------
> 1 file changed, 26 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 67fca439bbfb..24965e53d351 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1624,28 +1624,34 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
> frame.colorspace = HDMI_COLORSPACE_RGB;
>
> /* Set up colorimetry */
> - switch (hdmi->hdmi_data.enc_out_encoding) {
> - case V4L2_YCBCR_ENC_601:
> - if (hdmi->hdmi_data.enc_in_encoding == V4L2_YCBCR_ENC_XV601)
> - frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;
> - else
> + if (!hdmi_bus_fmt_is_rgb(hdmi->hdmi_data.enc_out_bus_format)) {
> + switch (hdmi->hdmi_data.enc_out_encoding) {
> + case V4L2_YCBCR_ENC_601:
> + if (hdmi->hdmi_data.enc_in_encoding == V4L2_YCBCR_ENC_XV601)
> + frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;
> + else
> + frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
> + frame.extended_colorimetry =
> + HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
> + break;
> + case V4L2_YCBCR_ENC_709:
> + if (hdmi->hdmi_data.enc_in_encoding == V4L2_YCBCR_ENC_XV709)
> + frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;
> + else
> + frame.colorimetry = HDMI_COLORIMETRY_ITU_709;
> + frame.extended_colorimetry =
> + HDMI_EXTENDED_COLORIMETRY_XV_YCC_709;
> + break;
> + default: /* Carries no data */
> frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
> + frame.extended_colorimetry =
> + HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
> + break;
> + }
> + } else {
> + frame.colorimetry = HDMI_COLORIMETRY_NONE;
> frame.extended_colorimetry =
> - HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
> - break;
> - case V4L2_YCBCR_ENC_709:
> - if (hdmi->hdmi_data.enc_in_encoding == V4L2_YCBCR_ENC_XV709)
> - frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;
> - else
> - frame.colorimetry = HDMI_COLORIMETRY_ITU_709;
> - frame.extended_colorimetry =
> - HDMI_EXTENDED_COLORIMETRY_XV_YCC_709;
> - break;
> - default: /* Carries no data */
> - frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
> - frame.extended_colorimetry =
> - HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
> - break;
> + HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
> }
>
> frame.scan_mode = HDMI_SCAN_MODE_NONE;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-03-02 9:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-29 16:30 [PATCH 0/4] drm/bridge: dw-hdmi: Various updates Jernej Skrabec
2020-02-29 16:30 ` [PATCH 1/4] drm/bridge: dw-hdmi: fix AVI frame colorimetry Jernej Skrabec
2020-03-02 9:21 ` Laurent Pinchart [this message]
2020-02-29 16:30 ` [PATCH 2/4] drm/bridge: dw-hdmi: Fix color space conversion detection Jernej Skrabec
2020-03-02 9:26 ` Neil Armstrong
2020-03-02 9:46 ` Jernej Škrabec
2020-03-02 16:42 ` Jernej Škrabec
2020-03-03 10:17 ` Neil Armstrong
2020-03-02 9:27 ` Laurent Pinchart
2020-03-02 12:45 ` Jernej Škrabec
2020-02-29 16:30 ` [PATCH 3/4] drm/bridge: dw-hdmi: do not force "none" scan mode Jernej Skrabec
2020-03-02 9:26 ` Neil Armstrong
2020-03-02 9:37 ` Laurent Pinchart
2020-02-29 16:30 ` [PATCH 4/4] drm/bridge: dw-hdmi: Add support for RGB limited range Jernej Skrabec
2020-03-02 9:53 ` Laurent Pinchart
2020-03-02 16:48 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302092124.GD11960@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).