From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: Jiri Slaby <jslaby@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pty: define and set show_fdinfo only if procfs is enabled
Date: Mon, 2 Mar 2020 11:51:53 +0100 [thread overview]
Message-ID: <20200302105153.GA39968@kroah.com> (raw)
In-Reply-To: <20200302104954.2812-1-tklauser@distanz.ch>
On Mon, Mar 02, 2020 at 11:49:53AM +0100, Tobias Klauser wrote:
> Follow the pattern used with other *_show_fdinfo functions and only
> define and use pty_show_fdinfo if CONFIG_PROC_FS is set.
if proc_fs is not set, it will not be used anyway, right?
I'd rather keep #ifdef out of the .c files than add this. How much
memory does it save, and are you using a system without procfs that
needs this savings?
thanks,
greg k-h
next prev parent reply other threads:[~2020-03-02 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 10:49 [PATCH 1/2] pty: define and set show_fdinfo only if procfs is enabled Tobias Klauser
2020-03-02 10:49 ` [PATCH 2/2] tty: " Tobias Klauser
2020-03-02 10:52 ` Greg Kroah-Hartman
2020-03-02 10:51 ` Greg Kroah-Hartman [this message]
2020-03-02 13:37 ` [PATCH 1/2] pty: " Tobias Klauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302105153.GA39968@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).