From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: Fix inverted check in gpiochip_remove()
Date: Mon, 2 Mar 2020 12:53:09 +0200 [thread overview]
Message-ID: <20200302105309.GP1224808@smile.fi.intel.com> (raw)
In-Reply-To: <20200302082448.11795-1-geert+renesas@glider.be>
On Mon, Mar 02, 2020 at 09:24:48AM +0100, Geert Uytterhoeven wrote:
> The optimization to check for requested lines actually optimized for the
> uncomon error case, where one of the GPIO lines is still in use.
> Hence the error message must be printed when the loop is terminated
> early, not when it went through all available GPIO lines.
>
> Fixes: 869233f81337bfb3 ("gpiolib: Optimize gpiochip_remove() when check for requested line")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Noticed by review, tested by creating and destroying an otherwise unused
> GPIO aggregator, which triggers:
>
> gpio gpiochip8: REMOVING GPIOCHIP WITH GPIOS STILL REQUESTED
Thank you!
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Linus, see below.
> ---
> drivers/gpio/gpiolib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 4e78bdc2739693c3..6180cf84fab7ce5e 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1823,7 +1823,7 @@ void gpiochip_remove(struct gpio_chip *chip)
> }
> spin_unlock_irqrestore(&gpio_lock, flags);
>
> - if (i == gdev->ngpio)
> + if (i != gdev->ngpio)
I prefer more explicit <.
I had sent a patch (before I noticed this), so it's up to Linus which one to choose.
> dev_crit(&gdev->dev,
> "REMOVING GPIOCHIP WITH GPIOS STILL REQUESTED\n");
>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-03-02 10:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 8:24 [PATCH] gpiolib: Fix inverted check in gpiochip_remove() Geert Uytterhoeven
2020-03-02 10:53 ` Andy Shevchenko [this message]
2020-03-03 12:34 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302105309.GP1224808@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).