From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Jonathan Hunter <jonathanh@nvidia.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Thierry Reding <thierry.reding@gmail.com>,
linux-tegra@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v1] media: staging: tegra-vde: Use devm_platform_ioremap_resource_byname()
Date: Mon, 2 Mar 2020 07:20:58 -0800 (PST) [thread overview]
Message-ID: <20200302152058.GB24372@kadam> (raw)
In-Reply-To: <d748bf2c-e38c-dabb-59ad-39e14813e40a@gmail.com>
On Mon, Mar 02, 2020 at 06:04:20PM +0300, Dmitry Osipenko wrote:
> 02.03.2020 11:04, Dan Carpenter пишет:
> > On Thu, Feb 27, 2020 at 09:09:15PM +0300, Dmitry Osipenko wrote:
> >> This helps to make code cleaner a tad.
> >
> > Please don't start the commit message in the middle of a sentence.
>
> Could you please clarify what do you mean by the "middle of a sentence"?
> The commit's message doesn't sound "middle" to me at all.
>
> > It looks like this for some of us:
> >
> > https://marc.info/?l=linux-driver-devel&m=158282701430176&w=2
>
> This link points to this patch, I don't quite understand what you're
> trying to convey here.
>
> > I generally read the subject or the full commit message but seldom
> > both.
>
> The commit's title describes the change briefly, while the message gives
> a rational for the change. Usually reviewer should consult the code
> changes themselves for more details.
>
> Do you have some kind of a email filter that shows only the commit's
> message? Otherwise I'm not sure what's the problem.
The commit message just says "This helps to make code cleaner a tad."
but it doesn't mention devm_platform_ioremap_resource_byname(). That
information is there in the subject but not in the commit message itself.
Take a look at the link I sent you and try to find the subject. It's
far away from the commit message.
regards,
dan carpenter
prev parent reply other threads:[~2020-03-02 15:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 18:09 [PATCH v1] media: staging: tegra-vde: Use devm_platform_ioremap_resource_byname() Dmitry Osipenko
2020-03-02 8:04 ` Dan Carpenter
2020-03-02 15:04 ` Dmitry Osipenko
2020-03-02 15:20 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302152058.GB24372@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=digetx@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).