From: Jakub Kicinski <kuba@kernel.org>
To: "Machulsky, Zorik" <zorik@amazon.com>
Cc: Josh Triplett <josh@joshtriplett.org>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Tzalik, Guy" <gtzalik@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ena: Speed up initialization 90x by reducing poll delays
Date: Mon, 2 Mar 2020 15:53:19 -0800 [thread overview]
Message-ID: <20200302155319.273ee513@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <8B4A52CD-FC5A-4256-B7DE-A659B50654CE@amazon.com>
On Mon, 2 Mar 2020 23:16:32 +0000 Machulsky, Zorik wrote:
> On 2/28/20, 4:29 PM, "Josh Triplett" <josh@joshtriplett.org> wrote:
>
> Before initializing completion queue interrupts, the ena driver uses
> polling to wait for responses on the admin command queue. The ena driver
> waits 5ms between polls, but the hardware has generally finished long
> before that. Reduce the poll time to 10us.
>
> On a c5.12xlarge, this improves ena initialization time from 173.6ms to
> 1.920ms, an improvement of more than 90x. This improves server boot time
> and time to network bringup.
>
> Thanks Josh,
> We agree that polling rate should be increased, but prefer not to do
> it aggressively and blindly. For example linear backoff approach
> might be a better choice. Please let us re-work a little this patch
> and bring it to review. Thanks!
Up to Josh if this is fine with him, but in my experience "let us rework
your patch behind the close doors" is not the response open source
contributors are expecting.
next prev parent reply other threads:[~2020-03-02 23:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-29 0:28 [PATCH] ena: Speed up initialization 90x by reducing poll delays Josh Triplett
2020-03-02 23:16 ` Machulsky, Zorik
2020-03-02 23:53 ` Jakub Kicinski [this message]
2020-03-03 0:43 ` Machulsky, Zorik
2020-03-03 0:39 ` Josh Triplett
2020-03-03 0:53 ` Machulsky, Zorik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302155319.273ee513@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=akiyano@amazon.com \
--cc=gtzalik@amazon.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).