From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9802C3F2C6 for ; Tue, 3 Mar 2020 23:54:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C909420866 for ; Tue, 3 Mar 2020 23:54:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728053AbgCCXy2 (ORCPT ); Tue, 3 Mar 2020 18:54:28 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:37230 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727707AbgCCXy1 (ORCPT ); Tue, 3 Mar 2020 18:54:27 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id AFDB215AABE8B; Tue, 3 Mar 2020 15:54:26 -0800 (PST) Date: Tue, 03 Mar 2020 15:54:26 -0800 (PST) Message-Id: <20200303.155426.707583465205863443.davem@davemloft.net> To: madalin.bucur@oss.nxp.com Cc: netdev@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, leoyang.li@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, madalin.bucur@nxp.com Subject: Re: [PATCH net 4/4] dpaa_eth: FMan erratum A050385 workaround From: David Miller In-Reply-To: <1583250939-24645-5-git-send-email-madalin.bucur@oss.nxp.com> References: <1583250939-24645-1-git-send-email-madalin.bucur@oss.nxp.com> <1583250939-24645-5-git-send-email-madalin.bucur@oss.nxp.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 03 Mar 2020 15:54:27 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Madalin Bucur Date: Tue, 3 Mar 2020 17:55:39 +0200 > +#define DPAA_FD_DATA_ALIGNMENT ((fman_has_errata_a050385()) ? \ You don't need parenthesis around that fman_has_errata_a050385() call. > +#define dpaa_bp_size(raw_size) ((SKB_WITH_OVERHEAD(raw_size)) & \ Similar again for SKB_WITH_OVERHEAD() Also, how often does this errata code trigger on effected platforms and what is the performance degradation from that? I don't see this analysis performed anywhere.