From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Felipe Balbi <balbi@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/3] devicetree: bindings: exynos: Add new compatible for Exynos5420 dwc3 clocks support
Date: Tue, 3 Mar 2020 10:46:19 +0100 [thread overview]
Message-ID: <20200303094619.GA20181@pi3> (raw)
In-Reply-To: <20200301212019.2248-2-linux.amoon@gmail.com>
On Sun, Mar 01, 2020 at 09:20:16PM +0000, Anand Moon wrote:
> This patch adds the new compatible string for Exynos5422 DWC3
> to support enable/disable of core and suspend clk by DWC3 driver.
> Also updated the clock names for compatible samsung,exynos5420-dwusb3.
Some time ago I mentioned this... so once more:
Do not use "This patch adds" but simple "Add".
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151
Best regards,
Krzysztof
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Previous changes:
> Added the missing clock name for Exynos5420 complatible
> ---
> Documentation/devicetree/bindings/usb/exynos-usb.txt | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt b/Documentation/devicetree/bindings/usb/exynos-usb.txt
> index 6aae1544f240..220f729ac8eb 100644
> --- a/Documentation/devicetree/bindings/usb/exynos-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt
> @@ -69,7 +69,9 @@ DWC3
> Required properties:
> - compatible: should be one of the following -
> "samsung,exynos5250-dwusb3": for USB 3.0 DWC3 controller on
> - Exynos5250/5420.
> + Exynos5250.
> + "samsung,exynos5420-dwusb3": for USB 3.0 DWC3 controller on
> + Exynos5420.
> "samsung,exynos5433-dwusb3": for USB 3.0 DWC3 controller on
> Exynos5433.
> "samsung,exynos7-dwusb3": for USB 3.0 DWC3 controller on Exynos7.
> @@ -82,6 +84,7 @@ Required properties:
> Following clock names shall be provided for different
> compatibles:
> - samsung,exynos5250-dwusb3: "usbdrd30",
> + - samsung,exynos5420-dwusb3: "usbdrd30", "usbdrd30_susp_clk",
> - samsung,exynos5433-dwusb3: "aclk", "susp_clk", "pipe_pclk",
> "phyclk",
> - samsung,exynos7-dwusb3: "usbdrd30", "usbdrd30_susp_clk",
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-03-03 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 21:20 [PATCHv2 0/3] Add support for suspend clk for Exynos5422 SoC Anand Moon
2020-03-01 21:20 ` [PATCHv2 1/3] devicetree: bindings: exynos: Add new compatible for Exynos5420 dwc3 clocks support Anand Moon
2020-03-03 9:46 ` Krzysztof Kozlowski [this message]
2020-03-05 4:07 ` Anand Moon
2020-03-04 17:00 ` Rob Herring
2020-03-15 9:28 ` Felipe Balbi
2020-03-01 21:20 ` [PATCHv2 2/3] ARM: dts: exynos: Add missing usbdrd3 suspend clk Anand Moon
2020-03-01 21:20 ` [PATCHv2 3/3] usb: dwc3: exynos: Add support for Exynos5422 " Anand Moon
2020-03-04 8:11 ` [PATCHv2 0/3] Add support for suspend clk for Exynos5422 SoC Krzysztof Kozlowski
2020-03-04 17:53 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303094619.GA20181@pi3 \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).