From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E32FFC3F2C6 for ; Tue, 3 Mar 2020 10:21:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C6631214D8 for ; Tue, 3 Mar 2020 10:21:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728510AbgCCKVu (ORCPT ); Tue, 3 Mar 2020 05:21:50 -0500 Received: from elvis.franken.de ([193.175.24.41]:49476 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726661AbgCCKVu (ORCPT ); Tue, 3 Mar 2020 05:21:50 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1j94gM-0006jL-00; Tue, 03 Mar 2020 11:21:46 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 29770C0EC4; Tue, 3 Mar 2020 11:18:18 +0100 (CET) Date: Tue, 3 Mar 2020 11:18:18 +0100 From: Thomas Bogendoerfer To: "H. Nikolaus Schaller" Cc: Paul Boddie , Paul Cercueil , Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , Miquel Raynal , Andi Kleen , Kees Cook , Krzysztof Kozlowski , Geert Uytterhoeven , "Eric W. Biederman" , devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com, stable@vger.kernel.org Subject: Re: [PATCH v5 2/5] MIPS: DTS: CI20: fix PMU definitions for ACT8600 Message-ID: <20200303101818.GA12103@alpha.franken.de> References: <02f18080fa0e0c214b40431749ca1ce514c53d37.1583005548.git.hns@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02f18080fa0e0c214b40431749ca1ce514c53d37.1583005548.git.hns@goldelico.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 29, 2020 at 08:45:45PM +0100, H. Nikolaus Schaller wrote: > There is a ACT8600 on the CI20 board and the bindings of the > ACT8865 driver have changed without updating the CI20 device > tree. Therefore the PMU can not be probed successfully and > is running in power-on reset state. > > Fix DT to match the latest act8865-regulator bindings. > > Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes") I see checkpatch warnings in this patch, could please fix them ? And please seperate fixes from improvments, thank you. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]