From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: "Alexander Potapenko" <glider@google.com>,
"open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
"Kees Cook" <keescook@chromium.org>,
"Jann Horn" <jannh@google.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Dmitriy Vyukov" <dvyukov@google.com>,
"Todd Kjos" <tkjos@google.com>
Subject: Re: [PATCH v2 2/3] binder: do not initialize locals passed to copy_from_user()
Date: Tue, 3 Mar 2020 17:15:54 +0300 [thread overview]
Message-ID: <20200303141554.GG4118@kadam> (raw)
In-Reply-To: <58c1f1bf6b30bd5c39184cd9c09f25a9b9d67a68.camel@perches.com>
On Tue, Mar 03, 2020 at 05:56:51AM -0800, Joe Perches wrote:
> > The real fix is to initialize everything manually, the automated
> > initialization is a hardenning feature which many people will disable.
> > So I don't think the hardenning needs to be perfect, it needs to simple
> > and fast.
>
> Dan, perhaps I don't understand you.
> Can you clarify what you mean?
I'm basically agreeing with you.
Even though copy_from_user() might only initialize part of the struct
we should just record that it initializes the struct without getting
bogged down in details. The annotation should be simple.
If the automated system to initialize stack variables doesn't work 100%
that's okay because it's a supplement and not a replacement for manually
initializing stack variables.
regards,
dan carpenter
next prev parent reply other threads:[~2020-03-03 14:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 13:04 [PATCH v2 1/3] compiler.h: define __no_initialize glider
2020-03-02 13:04 ` [PATCH v2 2/3] binder: do not initialize locals passed to copy_from_user() glider
2020-03-02 13:09 ` Joe Perches
2020-03-02 13:25 ` Alexander Potapenko
2020-03-02 13:52 ` Dan Carpenter
2020-03-02 13:58 ` Joe Perches
2020-03-02 18:17 ` Alexander Potapenko
2020-03-02 18:31 ` Jann Horn
2020-03-05 9:03 ` Rasmus Villemoes
2020-03-05 12:45 ` Jann Horn
2020-03-06 2:29 ` Al Viro
2020-03-02 18:50 ` Joe Perches
2020-03-03 9:14 ` Alexander Potapenko
2020-03-03 9:38 ` Dan Carpenter
2020-03-03 13:56 ` Joe Perches
2020-03-03 14:15 ` Dan Carpenter [this message]
2020-03-04 18:13 ` Kees Cook
2020-03-05 8:07 ` Dan Carpenter
2020-03-05 8:26 ` Kees Cook
2020-03-05 8:33 ` Alexander Potapenko
2020-03-02 17:38 ` Greg KH
2020-03-02 18:28 ` Alexander Potapenko
2020-03-02 13:04 ` [PATCH v2 3/3] sched/wait: avoid double initialization in ___wait_event() glider
2020-03-02 16:56 ` Todd Kjos
2020-03-02 18:03 ` Alexander Potapenko
2020-03-02 18:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303141554.GG4118@kadam \
--to=dan.carpenter@oracle.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jannh@google.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).