linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: zzyiwei@google.com, mingo@redhat.com, elder@kernel.org,
	federico.vaga@cern.ch, tony.luck@intel.com,
	vilhelm.gray@gmail.com, linus.walleij@linaro.org,
	tglx@linutronix.de, yamada.masahiro@socionext.com,
	paul.walmsley@sifive.com, bhelgaas@google.com, darekm@google.com,
	ndesaulniers@google.com, joelaf@google.com,
	linux-kernel@vger.kernel.org, prahladk@google.com,
	android-kernel@google.com
Subject: Re: [PATCH v4] gpu/trace: add a gpu total memory usage tracepoint
Date: Tue, 3 Mar 2020 16:56:39 +0100	[thread overview]
Message-ID: <20200303155639.GA437469@kroah.com> (raw)
In-Reply-To: <20200303093104.260b1946@gandalf.local.home>

On Tue, Mar 03, 2020 at 09:31:04AM -0500, Steven Rostedt wrote:
> On Tue, 3 Mar 2020 15:15:05 +0100
> Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> > On Tue, Mar 03, 2020 at 09:07:03AM -0500, Steven Rostedt wrote:
> > > 
> > > Greg,
> > > 
> > > You acked this patch before, did you want to ack it again, and I'll take it
> > > in my tree?  
> > 
> > Sure, but where did my ack go?  What changed from previous versions???
> > 
> > Anyway, the patch seems sane enough to me:
> > 
> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Your previous ack was was here:
> 
>   https://lore.kernel.org/lkml/20200213004029.GA2500609@kroah.com/

Yeah, I remember that.

> And the patch changed since then (although, only cosmetically), so your ack
> was removed. The diff between this patch and the patch you acked is this:
> 
> -- Steve
> 
> diff --git a/include/trace/events/gpu_mem.h b/include/trace/events/gpu_mem.h
> index 3b632a2b5100..1897822a9150 100644
> --- a/include/trace/events/gpu_mem.h
> +++ b/include/trace/events/gpu_mem.h
> @@ -28,34 +28,27 @@
>   *
>   */
>  TRACE_EVENT(gpu_mem_total,
> -	TP_PROTO(
> -		uint32_t gpu_id,
> -		uint32_t pid,
> -		uint64_t size
> -	),
> -	TP_ARGS(
> -		gpu_id,
> -		pid,
> -		size
> -	),
> +
> +	TP_PROTO(uint32_t gpu_id, uint32_t pid, uint64_t size),
> +
> +	TP_ARGS(gpu_id, pid, size),
> +
>  	TP_STRUCT__entry(
>  		__field(uint32_t, gpu_id)
>  		__field(uint32_t, pid)
>  		__field(uint64_t, size)
>  	),
> +
>  	TP_fast_assign(
>  		__entry->gpu_id = gpu_id;
>  		__entry->pid = pid;
>  		__entry->size = size;
>  	),
> -	TP_printk(
> -		"gpu_id=%u "
> -		"pid=%u "
> -		"size=%llu",
> +
> +	TP_printk("gpu_id=%u pid=%u size=%llu",
>  		__entry->gpu_id,
>  		__entry->pid,
> -		__entry->size
> -	)
> +		__entry->size)
>  );
>  
>  #endif /* _TRACE_GPU_MEM_H */

thanks for the diff, my ack still stands.

greg k-h

  parent reply	other threads:[~2020-03-03 15:56 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13  0:32 [PATCH v2] Add gpu memory tracepoints zzyiwei
2020-02-13  0:39 ` Yiwei Zhang
2020-02-13  0:40 ` Greg KH
2020-02-13  1:23   ` Yiwei Zhang
2020-02-13  1:48 ` Steven Rostedt
2020-02-13  2:20 ` zzyiwei
2020-02-13  2:24   ` Yiwei Zhang
2020-02-13  3:29     ` Steven Rostedt
2020-02-13  4:23       ` [PATCH v3] gpu/trace: add " zzyiwei
2020-02-13  4:27         ` Yiwei Zhang
2020-02-13 14:03         ` Steven Rostedt
2020-02-13 17:49           ` Yiwei Zhang
2020-02-24  6:31             ` Yiwei Zhang
2020-02-24 16:38               ` Steven Rostedt
2020-03-01  0:53                 ` Yiwei Zhang
2020-03-02 23:48                   ` [PATCH] [PATCH v4] gpu/trace: add a gpu total memory usage tracepoint zzyiwei
2020-03-02 23:56                     ` Yiwei Zhang
2020-03-02 23:50                   ` zzyiwei
2020-03-03 14:07                     ` Steven Rostedt
2020-03-03 14:15                       ` Greg KH
2020-03-03 14:31                         ` Steven Rostedt
2020-03-03 15:15                           ` Yiwei Zhang
2020-03-03 15:48                             ` Steven Rostedt
2020-03-03 15:56                           ` Greg KH [this message]
2020-03-13 22:59                             ` Yiwei Zhang
2020-03-16 18:05                               ` Steven Rostedt
2020-03-16 19:28                                 ` Yiwei Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200303155639.GA437469@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=android-kernel@google.com \
    --cc=bhelgaas@google.com \
    --cc=darekm@google.com \
    --cc=elder@kernel.org \
    --cc=federico.vaga@cern.ch \
    --cc=joelaf@google.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=ndesaulniers@google.com \
    --cc=paul.walmsley@sifive.com \
    --cc=prahladk@google.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=vilhelm.gray@gmail.com \
    --cc=yamada.masahiro@socionext.com \
    --cc=zzyiwei@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).