From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57C21C3F2D8 for ; Tue, 3 Mar 2020 17:59:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28DC420CC7 for ; Tue, 3 Mar 2020 17:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583258362; bh=osVklB8pscuOnNSyEep2Q6rChRj+SW+wKvUMrT7fdAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=g3O7fmis1HEjXrE+SAvS8P2ZYE5YR2ujP7aMmDJFJchjQatH7u5kMs7HqVyXY7+HD TTZIqkq3rRRX22rtaII/lZ/+S5OPU40rUwiwNYomaCgOIbJqeevudB9VGohO35CyMT SyPbbFz41kTa8Z9/sByrNt5HaDNYKHjBe0wxE6Y0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387588AbgCCR7V (ORCPT ); Tue, 3 Mar 2020 12:59:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:42524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732663AbgCCR7S (ORCPT ); Tue, 3 Mar 2020 12:59:18 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C950220CC7; Tue, 3 Mar 2020 17:59:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583258357; bh=osVklB8pscuOnNSyEep2Q6rChRj+SW+wKvUMrT7fdAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ma7dcFOXg9aUCRk4znsnDEtpkl5Na547GGkMdfLxx36TRxVgPIzoIO7ixdnkJ6VH9 jK3tXfXlUZMxv6NVTRw7oo7N0h1sGaXWTSu/mO+TqXiWKyvPU/rjYOBLk3YtRNBQ6l szK3eGkUmOlIyU6jr9+PrwzSJEm/aXkNYM/Yfb0M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sameeh Jubran , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 19/87] net: ena: rss: fix failure to get indirection table Date: Tue, 3 Mar 2020 18:43:10 +0100 Message-Id: <20200303174351.814793624@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200303174349.075101355@linuxfoundation.org> References: <20200303174349.075101355@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sameeh Jubran [ Upstream commit 0c8923c0a64fb5d14bebb9a9065d2dc25ac5e600 ] On old hardware, getting / setting the hash function is not supported while gettting / setting the indirection table is. This commit enables us to still show the indirection table on older hardwares by setting the hash function and key to NULL. Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)") Signed-off-by: Sameeh Jubran Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/amazon/ena/ena_ethtool.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/ethernet/amazon/ena/ena_ethtool.c b/drivers/net/ethernet/amazon/ena/ena_ethtool.c index 237fbcac734f5..dc63aa912aebb 100644 --- a/drivers/net/ethernet/amazon/ena/ena_ethtool.c +++ b/drivers/net/ethernet/amazon/ena/ena_ethtool.c @@ -661,7 +661,21 @@ static int ena_get_rxfh(struct net_device *netdev, u32 *indir, u8 *key, if (rc) return rc; + /* We call this function in order to check if the device + * supports getting/setting the hash function. + */ rc = ena_com_get_hash_function(adapter->ena_dev, &ena_func, key); + + if (rc) { + if (rc == -EOPNOTSUPP) { + key = NULL; + hfunc = NULL; + rc = 0; + } + + return rc; + } + if (rc) return rc; -- 2.20.1