From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22E81C3F2D1 for ; Tue, 3 Mar 2020 18:03:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA67A2072D for ; Tue, 3 Mar 2020 18:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583258585; bh=ysInNcKLbdIsDEaCJnZKFs/gLT63skhNXoWP42kIxjA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vfOX+1czMfEJRTN2fttHaNKLI2V7ikfWmUo2zV9RIc/AfaeEA2VuvGKXgWrb/CxwL hEdm6mQb65nVr/DhWgR7FkCWPKw864FzTrQG9EK8oPyVjN+NVJ5tQN6EZFfGvtErhw XlygfVUmGlhL0umyURrXYRyG5dY2PCLGvrmW59wE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387853AbgCCSDD (ORCPT ); Tue, 3 Mar 2020 13:03:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:46596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388132AbgCCSCF (ORCPT ); Tue, 3 Mar 2020 13:02:05 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 84B9F22B48; Tue, 3 Mar 2020 18:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583258525; bh=ysInNcKLbdIsDEaCJnZKFs/gLT63skhNXoWP42kIxjA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ci7yKt3uAjxwXWOVE2+mUDK/QBEBFh0nw+S8C4jVaUFKjdss7+cHUa1GoLaBAKKxw GW9jpac+/saNZ8+Esx5adhDCUeyIl/i1UaYdDS4rpLXeMs72s8Xj1txqzxJFsN8Tvk JgIajuWFCadQC4Z89riYg2iQoDcEWSuq2JnxtCvg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xin Long , Simon Horman , Pablo Neira Ayuso Subject: [PATCH 4.19 83/87] netfilter: nft_tunnel: no need to call htons() when dumping ports Date: Tue, 3 Mar 2020 18:44:14 +0100 Message-Id: <20200303174357.754083000@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200303174349.075101355@linuxfoundation.org> References: <20200303174349.075101355@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xin Long commit cf3e204a1ca5442190018a317d9ec181b4639bd6 upstream. info->key.tp_src and tp_dst are __be16, when using nla_put_be16() to dump them, htons() is not needed, so remove it in this patch. Fixes: af308b94a2a4 ("netfilter: nf_tables: add tunnel support") Signed-off-by: Xin Long Reviewed-by: Simon Horman Signed-off-by: Pablo Neira Ayuso Signed-off-by: Greg Kroah-Hartman --- net/netfilter/nft_tunnel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/netfilter/nft_tunnel.c +++ b/net/netfilter/nft_tunnel.c @@ -467,8 +467,8 @@ static int nft_tunnel_opts_dump(struct s static int nft_tunnel_ports_dump(struct sk_buff *skb, struct ip_tunnel_info *info) { - if (nla_put_be16(skb, NFTA_TUNNEL_KEY_SPORT, htons(info->key.tp_src)) < 0 || - nla_put_be16(skb, NFTA_TUNNEL_KEY_DPORT, htons(info->key.tp_dst)) < 0) + if (nla_put_be16(skb, NFTA_TUNNEL_KEY_SPORT, info->key.tp_src) < 0 || + nla_put_be16(skb, NFTA_TUNNEL_KEY_DPORT, info->key.tp_dst) < 0) return -1; return 0;