From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7D35C3F2D1 for ; Wed, 4 Mar 2020 09:03:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1EA920870 for ; Wed, 4 Mar 2020 09:03:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387773AbgCDJDQ (ORCPT ); Wed, 4 Mar 2020 04:03:16 -0500 Received: from mga09.intel.com ([134.134.136.24]:6453 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728387AbgCDJDQ (ORCPT ); Wed, 4 Mar 2020 04:03:16 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2020 01:03:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,513,1574150400"; d="scan'208";a="439060235" Received: from shao2-debian.sh.intel.com (HELO localhost) ([10.239.13.3]) by fmsmga005.fm.intel.com with ESMTP; 04 Mar 2020 01:03:11 -0800 Date: Wed, 4 Mar 2020 17:03:01 +0800 From: Rong Chen To: Alex Shi Cc: Andrew Morton , cgroups@vger.kernel.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, Michal Hocko , Vladimir Davydov , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v9 07/20] mm/lru: introduce TestClearPageLRU Message-ID: <20200304090301.GB5972@shao2-debian> References: <1583146830-169516-1-git-send-email-alex.shi@linux.alibaba.com> <1583146830-169516-8-git-send-email-alex.shi@linux.alibaba.com> <20200302141144.b30abe0d89306fd387e13a92@linux-foundation.org> <9cacdc21-9c1f-2a17-05cb-e9cf2959cef5@linux.alibaba.com> <20200303164659.b3a30ab9d68c9ed82299a29c@linux-foundation.org> <6d155f79-8ba2-b322-4e92-311e7be98f79@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6d155f79-8ba2-b322-4e92-311e7be98f79@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2020 at 03:06:48PM +0800, Alex Shi wrote: > > > 在 2020/3/4 上午8:46, Andrew Morton 写道: > > > > Well, any difference would be small and the numbers did get a bit > > lower, albeit probably within the margin of error. > > > > But you know, if someone were to send a patch which micro-optimized > > some code by replacing 'TestClearXXX()' with `if PageXXX() > > ClearPageXXX()', I would happily merge it! > > > > Is this change essential to the overall patchset? If not, I'd be > > inclined to skip it? > > > > Hi Andrew, > > Thanks a lot for comments! > Yes, this patch is essential for all next. > > Consider the normal memory testing would focus on user page, that probabably with PageLRU. > > Fengguang's vm-scalibicase-small-allocs which used a lots vm_area_struct slab, which may > got some impact. 0day/Cheng Rong is working on the test. In my roughly testing, it may drop 5% on my > 96threads/394GB machine. > > Thanks > Alex Hi, We only tested one case and found a slight regression of vm-scalability.median from this patch set: Test case: small allocs ========================================================================================= compiler/cpufreq_governor/kconfig/rootfs/runtime/tbox_group/test/testcase/ucode: gcc-7/performance/x86_64-rhel-7.6/debian-x86_64-20191114.cgz/300s/lkp-ivb-d02/small-allocs/vm-scalability/0x21 commit: v5.6-rc4 f71ed0f653e9dbd57347f6321e36556004a17b52 v5.6-rc4 f71ed0f653e9dbd57347f6321e3 ---------------- --------------------------- %stddev %change %stddev \ | \ 998930 -1.4% 984729 vm-scalability.median ========================================================================================= compiler/cpufreq_governor/kconfig/rootfs/runtime/tbox_group/test/testcase/ucode: gcc-7/performance/x86_64-rhel-7.6/debian-x86_64-20191114.cgz/300s/lkp-csl-2ap4/small-allocs/vm-scalability/0x500002c commit: v5.6-rc4 f71ed0f653e9dbd57347f6321e36556004a17b52 v5.6-rc4 f71ed0f653e9dbd57347f6321e3 ---------------- --------------------------- %stddev %change %stddev \ | \ 64040 -2.2% 62641 vm-scalability.median 12294118 -2.2% 12027483 vm-scalability.throughput 3.695e+09 -2.2% 3.614e+09 vm-scalability.workload $ git log --oneline v5.6-rc4..f71ed0f653e9dbd57347f6321e36556004a17b52 f71ed0f653e9d mm/memcg: add debug checking in lock_page_memcg c56d782a737a5 mm/lru: add debug checking for page memcg moving 40f9438e4f7a9 mm/lru: revise the comments of lru_lock cf4d433ab1f59 mm/pgdat: remove pgdat lru_lock 8b45216bf602c mm/swap: only change the lru_lock iff page's lruvec is different 9aeff27f856c4 mm/mlock: optimize munlock_pagevec by relocking 0fd16f50f4260 mm/lru: introduce the relock_page_lruvec function e8bcc2440b133 mm/lru: replace pgdat lru_lock with lruvec lock 88013de2d9cfa mm/mlock: clean up __munlock_isolate_lru_page 037f0e01cc3a3 mm/memcg: move SetPageLRU out of lru_lock in commit_charge 5f889edacd91d mm/lru: take PageLRU first in moving page between lru lists 06998f054a82b mm/mlock: ClearPageLRU before get lru lock in munlock page isolation 5212e3636eed6 mm/lru: add page isolation precondition in __isolate_lru_page a7b8b29f36b13 mm/lru: introduce TestClearPageLRU f27e8da1e2fa1 mm/thp: narrow lru locking 2deca0177d843 mm/thp: clean up lru_add_page_tail afbe030c47e06 mm/thp: move lru_add_page_tail func to huge_memory.c 9bee24913b538 mm/page_idle: no unlikely double check for idle page counting 40def76b96d7b mm/memcg: fold lock_page_lru into commit_charge c1199696673c2 mm/vmscan: remove unnecessary lruvec adding Best Regards, Rong Chen