From: Peter Zijlstra <peterz@infradead.org>
To: hpa@zytor.com
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
rjw@rjwysocki.net, lenb@kernel.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, luto@kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] x86/acpi: make "asmlinkage" part first thing in the function definition
Date: Wed, 4 Mar 2020 11:04:38 +0100 [thread overview]
Message-ID: <20200304100437.GM2596@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <9947D7CB-B9CD-47E0-BC5E-C7FC3A81FC7B@zytor.com>
On Wed, Mar 04, 2020 at 12:54:09AM -0800, hpa@zytor.com wrote:
> On March 3, 2020 12:41:44 PM PST, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >g++ insists that function declaration must start with extern "C"
> >(which asmlinkage expands to).
> >
> >gcc doesn't care.
> >
> >Signed-off-by: _Z6Alexeyv <adobriyan@gmail.com>
> >---
> >
> > arch/x86/kernel/acpi/sleep.c | 2 +-
> > arch/x86/kernel/acpi/sleep.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> >--- a/arch/x86/kernel/acpi/sleep.c
> >+++ b/arch/x86/kernel/acpi/sleep.c
> >@@ -43,7 +43,7 @@ unsigned long acpi_get_wakeup_address(void)
> > *
> > * Wrapper around acpi_enter_sleep_state() to be called by assmebly.
> > */
> >-acpi_status asmlinkage __visible x86_acpi_enter_sleep_state(u8 state)
> >+asmlinkage acpi_status __visible x86_acpi_enter_sleep_state(u8 state)
> > {
> > return acpi_enter_sleep_state(state);
> > }
> >--- a/arch/x86/kernel/acpi/sleep.h
> >+++ b/arch/x86/kernel/acpi/sleep.h
> >@@ -19,4 +19,4 @@ extern void do_suspend_lowlevel(void);
> >
> > extern int x86_acpi_suspend_lowlevel(void);
> >
> >-acpi_status asmlinkage x86_acpi_enter_sleep_state(u8 state);
> >+asmlinkage acpi_status x86_acpi_enter_sleep_state(u8 state);
>
> Are you building the kernel with C++?!
He is :-) IIRC he's got a whole bunch of patches that removes all the
C++ keywords from the kernel.
next prev parent reply other threads:[~2020-03-04 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 20:41 [PATCH] x86/acpi: make "asmlinkage" part first thing in the function definition Alexey Dobriyan
2020-03-04 8:54 ` hpa
2020-03-04 10:04 ` Peter Zijlstra [this message]
2020-03-04 10:10 ` hpa
2020-03-05 18:41 ` Alexey Dobriyan
2020-03-14 9:33 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304100437.GM2596@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=adobriyan@gmail.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).