From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E69EC3F2D1 for ; Wed, 4 Mar 2020 22:42:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5299620866 for ; Wed, 4 Mar 2020 22:42:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="isdY1aSX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388539AbgCDWmm (ORCPT ); Wed, 4 Mar 2020 17:42:42 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:40974 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388507AbgCDWmm (ORCPT ); Wed, 4 Mar 2020 17:42:42 -0500 Received: by mail-pg1-f195.google.com with SMTP id b1so1703125pgm.8 for ; Wed, 04 Mar 2020 14:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=odK5+dhUnBqo/+13PepNr/CkWlUjNgQ8JDVfrKhakIk=; b=isdY1aSXFghm/7DcPvO2xsBI6RsGzX4b5UMukog5rXaPNNa7gW8dJ13PYJNrekz4Tc dH4RUdCfN25tOEOdXai1KnSscbdIv6B+XYH1HTrplPOXWVVZ5MkyAkwJesiA2LZ15dDh +pBQqERRnjfEMP/stih8i95gBD6GNbY6FH3dI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=odK5+dhUnBqo/+13PepNr/CkWlUjNgQ8JDVfrKhakIk=; b=d5GcP4OKd6TbNDRYAom4Xbnw0Wcf+fOxgu+JZkm/EXIZF/6oJbaFLScSJrnXJQMjUK CJdfLPsaMeVsuqB5CNVQbjKhKCmUTgzKDgn0hVoFakKTu/3l3XoWWU/hxF1O8bWsFtHx QmDcav+/yYCBW/Aq/7pWthHGVzO6CkfDZdZXoMz0bhKcI4m/Kc97z6y4B0YtKra9q8yP 23XaUhfMDt2VLuvUunZO3BIbD81xIGQ1li8A6GpI9aGNfLGsvCfcteV9EnFfGZkrRmem TIh8OE1qxp4KBuJoJOro/QjK6B0QItia4/iesITFNTPHMt/ZgpmlMw3H2R3GJQB0pFF/ XfhA== X-Gm-Message-State: ANhLgQ1GfMxh/nLJ1d+pxKuJgzJIA0fNXwuih9ETeWe4mDKGQJavB/qi n06IVKBOHeifJfsjuoVGcN6oXw== X-Google-Smtp-Source: ADFU+vuKmczxGP4mpY9UFRgyIrH5RPg53yiVBl1Tz6nWTwaU/eXHWFgTXsBhMOZfJPQKyh0YI4ZA9w== X-Received: by 2002:aa7:8695:: with SMTP id d21mr5208658pfo.199.1583361760528; Wed, 04 Mar 2020 14:42:40 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w81sm15677072pff.22.2020.03.04.14.42.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 14:42:39 -0800 (PST) Date: Wed, 4 Mar 2020 14:42:38 -0800 From: Kees Cook To: Shuah Khan Cc: shuah@kernel.org, luto@amacapital.net, wad@chromium.org, daniel@iogearbox.net, kafai@fb.com, yhs@fb.com, andriin@fb.com, gregkh@linuxfoundation.org, tglx@linutronix.de, khilman@baylibre.com, mpe@ellerman.id.au, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 2/4] selftests: Fix seccomp to support relocatable build (O=objdir) Message-ID: <202003041442.A46000C@keescook> References: <11967e5f164f0cd717921bd382ff9c13ef740146.1583358715.git.skhan@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11967e5f164f0cd717921bd382ff9c13ef740146.1583358715.git.skhan@linuxfoundation.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2020 at 03:13:33PM -0700, Shuah Khan wrote: > Fix seccomp relocatable builds. This is a simple fix to use the > right lib.mk variable TEST_GEN_PROGS for objects to leverage > lib.mk common framework for relocatable builds. > > Signed-off-by: Shuah Khan > --- > tools/testing/selftests/seccomp/Makefile | 16 +++------------- > 1 file changed, 3 insertions(+), 13 deletions(-) > > diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile > index 1760b3e39730..a8a9717fc1be 100644 > --- a/tools/testing/selftests/seccomp/Makefile > +++ b/tools/testing/selftests/seccomp/Makefile > @@ -1,17 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > -all: > - > -include ../lib.mk > - > -.PHONY: all clean > - > -BINARIES := seccomp_bpf seccomp_benchmark > CFLAGS += -Wl,-no-as-needed -Wall > +LDFLAGS += -lpthread > > -seccomp_bpf: seccomp_bpf.c ../kselftest_harness.h How is the ../kselftest_harness.h dependency detected in the resulting build rules? Otherwise, looks good. -Kees > - $(CC) $(CFLAGS) $(LDFLAGS) $< -lpthread -o $@ > - > -TEST_PROGS += $(BINARIES) > -EXTRA_CLEAN := $(BINARIES) > +TEST_GEN_PROGS := seccomp_bpf seccomp_benchmark > > -all: $(BINARIES) > +include ../lib.mk > -- > 2.20.1 > -- Kees Cook