From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04DAFC3F2D1 for ; Thu, 5 Mar 2020 08:08:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D12A62166E for ; Thu, 5 Mar 2020 08:08:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="0LahpNy8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726183AbgCEII1 (ORCPT ); Thu, 5 Mar 2020 03:08:27 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:32816 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725880AbgCEII1 (ORCPT ); Thu, 5 Mar 2020 03:08:27 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0257x5Ui144820; Thu, 5 Mar 2020 08:08:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=yNpTxiFZxzT52KNk7sTPHiFNeGp2ohEATiVHyZEZpRY=; b=0LahpNy8BuvoDcNlmn75lZ7+QawrnaJjdZN7UO2Qnrp86kGPbev928IPl1KiKKIXLMwJ oBJQFj+e1X4lkCg8Lpbg9y3hlr2VC0W1Ox/r6lhQ1QynffpT4H0KwZWF00OyAhYewOMr 2MbtbWhEwAMidTGIpuYTUXxLSkwgosOcLzH0YmGKNbc57MabG3ofJ/QO/Qjk1pcX2Qx/ 9MG7nZJVtCUcgZqg6KouBk1piMcCkl0LHeppb+1PfWxc2u70BbTCAwlc9rWn89dHg1jT jNHTsz3lrYI1LxSmzWcDmQ0KEQ48EhYtQM8dcCoPmBS3h8Y3VhzFtPhC8J/nXEe7N0VC Mw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2yghn3f7y1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Mar 2020 08:08:10 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0257uln1154940; Thu, 5 Mar 2020 08:08:10 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2yjuf0ars6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 Mar 2020 08:08:10 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 025886DS029457; Thu, 5 Mar 2020 08:08:07 GMT Received: from kadam (/41.210.146.162) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 05 Mar 2020 00:08:06 -0800 Date: Thu, 5 Mar 2020 11:07:56 +0300 From: Dan Carpenter To: Kees Cook Cc: "open list:ANDROID DRIVERS" , Jann Horn , Peter Zijlstra , Greg Kroah-Hartman , LKML , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Ingo Molnar , Alexander Potapenko , Joe Perches , Dmitriy Vyukov , Todd Kjos Subject: Re: [PATCH v2 2/3] binder: do not initialize locals passed to copy_from_user() Message-ID: <20200305080756.GB19839@kadam> References: <20200302130430.201037-1-glider@google.com> <20200302130430.201037-2-glider@google.com> <0eaac427354844a4fcfb0d9843cf3024c6af21df.camel@perches.com> <4cac10d3e2c03e4f21f1104405a0a62a853efb4e.camel@perches.com> <18b0d6ea5619c34ca4120a6151103dbe9bfa0cbe.camel@perches.com> <20200303093832.GD24372@kadam> <202003040951.7857DFD936@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202003040951.7857DFD936@keescook> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9550 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003050050 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9550 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 spamscore=0 impostorscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 lowpriorityscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003050050 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2020 at 10:13:40AM -0800, Kees Cook wrote: > On Tue, Mar 03, 2020 at 12:38:32PM +0300, Dan Carpenter wrote: > > The real fix is to initialize everything manually, the automated > > initialization is a hardenning feature which many people will disable. > > I cannot disagree more with this sentiment. Linus has specifically said he > wants this initialization on by default[1], Fine, but as long as it's a configurable thing then we need to manually initialize as well or it's still a CVE etc. It will take a while before we drop support for old versions of GCC as well. regards, dan carpenter