From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2784EC3F2D2 for ; Thu, 5 Mar 2020 17:34:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4FD82072D for ; Thu, 5 Mar 2020 17:34:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LWAX/mnH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726485AbgCEReu (ORCPT ); Thu, 5 Mar 2020 12:34:50 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:37024 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbgCEReu (ORCPT ); Thu, 5 Mar 2020 12:34:50 -0500 Received: by mail-pf1-f194.google.com with SMTP id p14so3093479pfn.4 for ; Thu, 05 Mar 2020 09:34:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xEAJ1NUXPHu81BkE5lRF70aT//8/AuwgSjMAA/AA9VY=; b=LWAX/mnHWCEyMQS79Ze1HibVuhsx2iRhWybu/OIfRIhEMmxafA+jO26+0CcM8GqZKp bj465loQBo/50XZIGBZ/ylnMWfJX66dz1JBN7/OtzDfydSHSgNy9SDYwXcCo8Xg96Vmr Yt9ah3j9GlG/34Y7n1Z4iDB3Jgr4sgDvvLFHM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xEAJ1NUXPHu81BkE5lRF70aT//8/AuwgSjMAA/AA9VY=; b=S/AK6btbvs6aYZtb/Bt0zM23AL2UTMFMa7/ZWL20VdEBIDiTChydpLS1b4YaSMegDR bHQiOO+WyY+pp5CwDVp67b5CCw99eSPnOyyKWqkrAPyOxAoflcUCAa0rNyGCiXnMb5By oi8K/DlRzfvmSNdOXnBNSoqC1Aj8/Bd11XO5zK9dOcOaKGnQeoFrB4iFaUw4Cg9i8Wl0 kb06XMRkqyNMu8rKKh+7gHse4hPUMt0WuqEhAbpDMoCgZXtIL7fPtOdpRC2wE0BE5pPY zGS53zNnD4ltAdydWqcUXTcJj6zPeW7UNIWE27ooB5SVbv8N5x8L1RXLxgkW6+b8lCeu h0Mw== X-Gm-Message-State: ANhLgQ3NMHhyJHaeM15Kly+mPgigt8vzBd/mxGVuxtyMgD7377/t+hGn CcPmNEd05mvXMqC9BDSL26UzJg== X-Google-Smtp-Source: ADFU+vuqTfC7B4BJz1/7pVQ/CWvKBqNiVRzuaTrFyEVgzlwk4wZWRxHJIk8rQLzAzPTg3iuU6kJDPA== X-Received: by 2002:a63:7f14:: with SMTP id a20mr3441343pgd.428.1583429689456; Thu, 05 Mar 2020 09:34:49 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h29sm29954099pfk.57.2020.03.05.09.34.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2020 09:34:48 -0800 (PST) Date: Thu, 5 Mar 2020 09:34:47 -0800 From: Kees Cook To: Arvind Sankar Cc: John Paul Adrian Glaubitz , Joe Perches , "Tobin C . Harding" , Tycho Andersen , kernel-hardening@lists.openwall.com, Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sh: Stop printing the virtual memory layout Message-ID: <202003050933.14BDEDBF1@keescook> References: <202003021038.8F0369D907@keescook> <20200305151010.835954-1-nivedita@alum.mit.edu> <31d1567c4c195f3bc5c6b610386cf0f559f9094f.camel@perches.com> <3c628a5a-35c7-3d92-b94b-23704500f7c4@physik.fu-berlin.de> <20200305154657.GA848330@rani.riverdale.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200305154657.GA848330@rani.riverdale.lan> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 05, 2020 at 10:46:58AM -0500, Arvind Sankar wrote: > On Thu, Mar 05, 2020 at 04:41:05PM +0100, John Paul Adrian Glaubitz wrote: > > On 3/5/20 4:38 PM, Joe Perches wrote: > > >> Aww, why wasn't this made configurable? I found these memory map printouts > > >> very useful for development. > > > > > > It could be changed from pr_info to pr_devel. > > > > > > A #define DEBUG would have to be added to emit it. > > > > Well, from the discussion it seems the decision to cut it out has already been > > made, so I guess it's too late :(. > > > > Adrian > > > > -- > > .''`. John Paul Adrian Glaubitz > > : :' : Debian Developer - glaubitz@debian.org > > `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de > > `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 > > Not really too late. I can do s/pr_info/pr_devel and resubmit. > > parisc for eg actually hides this in #if 0 rather than deleting the > code. > > Kees, you fine with that? I don't mind pr_devel(). ("#if 0" tends to lead to code-rot since it's not subjected to syntax checking in case the names of things change.) That said, it's really up to the arch maintainers. -- Kees Cook