From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Allison Randal <allison@lohutok.net>,
Enrico Weigelt <info@metux.net>,
Stephen Boyd <swboyd@chromium.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: i8042 - Fix the selftest retry logic
Date: Thu, 5 Mar 2020 20:16:42 -0800 [thread overview]
Message-ID: <20200306041642.GD217608@dtor-ws> (raw)
In-Reply-To: <20200305064423.16196-1-acelan.kao@canonical.com>
Hi AceLan,
On Thu, Mar 05, 2020 at 02:44:23PM +0800, AceLan Kao wrote:
> It returns -NODEV at the first selftest timeout, so the retry logic
> doesn't work. Move the return outside of the while loop to make it real
> retry 5 times before returns -ENODEV.
The retry logic here was for the controller not returning the expected
selftest value, not the controller refusing to communicate at all.
Could you pease tell me what device requires this change?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2020-03-06 4:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 6:44 [PATCH] Input: i8042 - Fix the selftest retry logic AceLan Kao
2020-03-06 4:16 ` Dmitry Torokhov [this message]
2020-03-06 6:40 ` AceLan Kao
2020-03-10 3:35 ` You-Sheng Yang
2020-03-10 3:36 ` [PATCH v2] Input: i8042 - fix " You-Sheng Yang
2020-03-17 4:22 ` AceLan Kao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306041642.GD217608@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=acelan.kao@canonical.com \
--cc=allison@lohutok.net \
--cc=info@metux.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).