From: Alex Elder <elder@linaro.org>
To: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Arnd Bergmann <arnd@arndb.de>,
Masahiro Yamada <masahiroy@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] bitfield.h: add FIELD_MAX() and field_max()
Date: Thu, 5 Mar 2020 22:23:02 -0600 [thread overview]
Message-ID: <20200306042302.17602-1-elder@linaro.org> (raw)
Define FIELD_MAX(), which supplies the maximum value that can be
represented by a bitfield. Define field_max() as well, to go
along with the lower-case forms of the field mask functions.
Signed-off-by: Alex Elder <elder@linaro.org>
Acked-by: Jakub Kicinski <kuba@kernel.org>
---
v2: Added Acked-by from Jakub.
David, I added you to this because it's probably easiest to take
this change in through your tree with the rest of the IPA code
(which uses field_max(), defined here).
-Alex
include/linux/bitfield.h | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/include/linux/bitfield.h b/include/linux/bitfield.h
index 4bbb5f1c8b5b..48ea093ff04c 100644
--- a/include/linux/bitfield.h
+++ b/include/linux/bitfield.h
@@ -55,6 +55,19 @@
(1ULL << __bf_shf(_mask))); \
})
+/**
+ * FIELD_MAX() - produce the maximum value representable by a field
+ * @_mask: shifted mask defining the field's length and position
+ *
+ * FIELD_MAX() returns the maximum value that can be held in the field
+ * specified by @_mask.
+ */
+#define FIELD_MAX(_mask) \
+ ({ \
+ __BF_FIELD_CHECK(_mask, 0ULL, 0ULL, "FIELD_MAX: "); \
+ (typeof(_mask))((_mask) >> __bf_shf(_mask)); \
+ })
+
/**
* FIELD_FIT() - check if value fits in the field
* @_mask: shifted mask defining the field's length and position
@@ -110,6 +123,7 @@ static __always_inline u64 field_mask(u64 field)
{
return field / field_multiplier(field);
}
+#define field_max(field) ((typeof(field))field_mask(field))
#define ____MAKE_OP(type,base,to,from) \
static __always_inline __##type type##_encode_bits(base v, base field) \
{ \
--
2.20.1
next reply other threads:[~2020-03-06 4:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 4:23 Alex Elder [this message]
2020-03-10 21:29 ` [PATCH v2] bitfield.h: add FIELD_MAX() and field_max() Nathan Chancellor
2020-03-10 21:58 ` Jakub Kicinski
2020-03-11 1:48 ` Alex Elder
2020-03-11 2:45 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306042302.17602-1-elder@linaro.org \
--to=elder@linaro.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).