From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDD83C10DCE for ; Fri, 6 Mar 2020 19:02:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE83A206D5 for ; Fri, 6 Mar 2020 19:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583521325; bh=d5l9TmIroeO1eBxz7Un/dH825zdsp6k7qVptxvn42TY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=uzPpTt5BJPbsf3Yh5RtR1H/Nu2U9jva75dxV4IVcLsFykbfwUE1qTidiy0dKSXKxd kCtKCumTahKMXm98H1FKint2bTygAxFFx/ANRzjnqm0ZZ2AyVf8lLsBZfjHME4QqBL zElaGlf4GR0o6rsTbW5FMPTfMRSmIESTTDZQl16c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726635AbgCFTCE (ORCPT ); Fri, 6 Mar 2020 14:02:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:36936 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbgCFTCE (ORCPT ); Fri, 6 Mar 2020 14:02:04 -0500 Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6FE2520637; Fri, 6 Mar 2020 19:02:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583521323; bh=d5l9TmIroeO1eBxz7Un/dH825zdsp6k7qVptxvn42TY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Sm5Xn3MM059FvZ67/Nk160OCwFmuAK2CUpVbNFEVImqFNED8ayo4B4wujLAPnaC1t ntSVwEFq3WibKes8WkdjzgtdZW9GdMz21aHqh3ycmXWgbZjLpWxZd3NTtE32o++mrn KiQsHzUCwVAFm/IhT9/g18Jwios2z+QgzosWe6T0= Date: Fri, 6 Mar 2020 11:02:00 -0800 From: Jakub Kicinski To: Po Liu Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, vinicius.gomes@intel.com, claudiu.manoil@nxp.com, vladimir.oltean@nxp.com, alexandru.marginean@nxp.com, xiaoliang.yang_1@nxp.com, roy.zang@nxp.com, mingkai.hu@nxp.com, jerry.huang@nxp.com, leoyang.li@nxp.com, michael.chan@broadcom.com, vishal@chelsio.com, saeedm@mellanox.com, leon@kernel.org, jiri@mellanox.com, idosch@mellanox.com, alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, john.hurley@netronome.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, pablo@netfilter.org, moshe@mellanox.com, ivan.khoronzhuk@linaro.org, m-karicheri2@ti.com, andre.guedes@linux.intel.com, jakub.kicinski@netronome.com Subject: Re: [RFC,net-next 3/9] net: schedule: add action gate offloading Message-ID: <20200306110200.5fc47ad7@kicinski-fedora-PC1C0HJN> In-Reply-To: <20200306125608.11717-4-Po.Liu@nxp.com> References: <20200306125608.11717-1-Po.Liu@nxp.com> <20200306125608.11717-4-Po.Liu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 6 Mar 2020 20:56:01 +0800 Po Liu wrote: > +static int tcf_gate_get_entries(struct flow_action_entry *entry, > + const struct tc_action *act) > +{ > + entry->gate.entries = tcf_gate_get_list(act); > + > + if (!entry->gate.entries) > + return -EINVAL; > + > + entry->destructor = tcf_gate_entry_destructor; > + entry->destructor_priv = entry->gate.entries; What's this destructor stuff doing? I don't it being called. > + return 0; > +}