From: Marc Zyngier <maz@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v2 3/6] irq/domain: add a new callback to domain ops
Date: Sun, 8 Mar 2020 13:51:17 +0000 [thread overview]
Message-ID: <20200308135117.7c60c881@why> (raw)
In-Reply-To: <20200211131240.15853-4-brgl@bgdev.pl>
On Tue, 11 Feb 2020 14:12:37 +0100
Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Add the remove() callback to irq_domain_ops which can be used to
> automatically dispose of any host data associated with the domain when
> irq_domain_remove() is called.
I have a hard time buying this. Whatever data that is associated to the
domain is already owned known by whoever created the domain the first
place.
Since the expected use case is that whoever created the domain also
destroys it, the caller is already in a position to do its own cleanup,
and we don't need any of this.
So please explain what you are trying to achieve here.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-03-08 13:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 13:12 [PATCH v2 0/6] irq/irq_sim: try to improve the API Bartosz Golaszewski
2020-02-11 13:12 ` [PATCH v2 1/6] irq: make irq_domain_reset_irq_data() available even for non-V2 users Bartosz Golaszewski
2020-02-14 9:02 ` Thomas Gleixner
2020-02-14 9:31 ` Bartosz Golaszewski
2020-02-11 13:12 ` [PATCH v2 2/6] irq/irq_sim: simplify the API Bartosz Golaszewski
2020-02-11 13:12 ` [PATCH v2 3/6] irq/domain: add a new callback to domain ops Bartosz Golaszewski
2020-03-08 13:51 ` Marc Zyngier [this message]
2020-03-08 17:59 ` Bartosz Golaszewski
2020-03-12 8:15 ` Bartosz Golaszewski
2020-03-20 9:38 ` Bartosz Golaszewski
2020-02-11 13:12 ` [PATCH v2 4/6] irq/irq_sim: remove irq_domain_remove_sim() Bartosz Golaszewski
2020-02-11 13:12 ` [PATCH v2 5/6] irq/domain: provide irq_domain_dispose_mappings() helper Bartosz Golaszewski
2020-02-11 13:12 ` [PATCH v2 6/6] irqchip: keystone: use irq_domain_dispose_mappings() Bartosz Golaszewski
2020-03-03 7:57 ` [PATCH v2 0/6] irq/irq_sim: try to improve the API Bartosz Golaszewski
2020-04-13 17:07 ` Jonathan Cameron
2020-04-14 8:37 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200308135117.7c60c881@why \
--to=maz@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=jason@lakedaemon.net \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).