From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 243FFC18E5A for ; Mon, 9 Mar 2020 08:54:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 037D220637 for ; Mon, 9 Mar 2020 08:54:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726497AbgCIIyP (ORCPT ); Mon, 9 Mar 2020 04:54:15 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:39174 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726360AbgCIIyP (ORCPT ); Mon, 9 Mar 2020 04:54:15 -0400 Received: from gwarestrin.me.apana.org.au ([192.168.0.7] helo=gwarestrin.arnor.me.apana.org.au) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1jBEAK-0007Ty-1N; Mon, 09 Mar 2020 19:53:37 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Mon, 09 Mar 2020 19:53:35 +1100 Date: Mon, 9 Mar 2020 19:53:35 +1100 From: Herbert Xu To: Zhenzhong Duan Cc: linux-kernel@vger.kernel.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, miguel.ojeda.sandonis@gmail.com, willy@haproxy.com, ksenija.stanojevic@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, mpm@selenic.com, jonathan@buzzard.org.uk, benh@kernel.crashing.org, davem@davemloft.net, b.zolnierkie@samsung.com, rjw@rjwysocki.net, pavel@ucw.cz, len.brown@intel.com Subject: Re: [PATCH RFC 1/3] misc: cleanup minor number definitions in c file into miscdevice.h Message-ID: <20200309085335.GA14776@gondor.apana.org.au> References: <20200309021747.626-1-zhenzhong.duan@gmail.com> <20200309021747.626-2-zhenzhong.duan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200309021747.626-2-zhenzhong.duan@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2020 at 10:17:45AM +0800, Zhenzhong Duan wrote: > HWRNG_MINOR and RNG_MISCDEV_MINOR are duplicate definitions, use > unified RNG_MINOR instead and moved into miscdevice.h Please keep the HWRNG_MINOR name, RNG_MINOR could cause confusion. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt