linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Willy TARREAU <wtarreau@haproxy.com>
To: Zhenzhong Duan <zhenzhong.duan@gmail.com>
Cc: linux-kernel@vger.kernel.org, jdike@addtoit.com, richard@nod.at,
	anton.ivanov@cambridgegreys.com, miguel.ojeda.sandonis@gmail.com,
	ksenija.stanojevic@gmail.com, arnd@arndb.de,
	gregkh@linuxfoundation.org, mpm@selenic.com,
	herbert@gondor.apana.org.au, jonathan@buzzard.org.uk,
	benh@kernel.crashing.org, davem@davemloft.net,
	b.zolnierkie@samsung.com, rjw@rjwysocki.net, pavel@ucw.cz,
	len.brown@intel.com
Subject: Re: [PATCH RFC 0/3] clean up misc device minor numbers
Date: Mon, 9 Mar 2020 10:51:02 +0100	[thread overview]
Message-ID: <20200309095102.GA13722@haproxy.com> (raw)
In-Reply-To: <20200309021747.626-1-zhenzhong.duan@gmail.com>

On Mon, Mar 09, 2020 at 10:17:44AM +0800, Zhenzhong Duan wrote:
> Some the misc device minor numbers definitions spread in different
> local c files, specially some are duplicate number with different
> name, some are same name with conflict numbers, some prefer dynamic
> minors.
> 
> This patchset try to address all of them.

Thanks for this! When I initially created panel.c about 20 years ago
I didn't even realize there was a miscdevice.h to centralize all this.
It's definitely cleaner this way.

> To be honest, I didn't try build on arm or sparc arch which some
> drivers depend on as I have little experience on cross-compile.
> But I still checked the patch carefully to ensure it builds
> in theory. Appreciate if anyone willing to test build on those arch.

So I've built for ARM to check, I could enable and successfully build
these modules that you touched: charlcd, panel, applicom, devsynth,
speakup_soft. The other ones might require less obvious configs to be
build-tested.

Willy

  parent reply	other threads:[~2020-03-09 10:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09  2:17 [PATCH RFC 0/3] clean up misc device minor numbers Zhenzhong Duan
2020-03-09  2:17 ` [PATCH RFC 1/3] misc: cleanup minor number definitions in c file into miscdevice.h Zhenzhong Duan
2020-03-09  8:53   ` Herbert Xu
2020-03-11  3:07     ` Zhenzhong Duan
2020-03-09 11:37   ` Miguel Ojeda
2020-03-09 13:08   ` Arnd Bergmann
2020-03-11  2:57     ` Zhenzhong Duan
2020-03-09  2:17 ` [PATCH RFC 2/3] misc: move FLASH_MINOR into miscdevice.h and fix conflicts Zhenzhong Duan
2020-03-09 13:05   ` Arnd Bergmann
2020-03-09  2:17 ` [PATCH RFC 3/3] speakup: misc: Use dynamic minor numbers for speakup devices Zhenzhong Duan
2020-03-09  7:15   ` Greg KH
2020-03-14 22:21     ` Samuel Thibault
2020-03-09  7:13 ` [PATCH RFC 0/3] clean up misc device minor numbers Greg KH
2020-03-09  9:51 ` Willy TARREAU [this message]
2020-03-09 11:36   ` Miguel Ojeda
2020-03-11  3:14     ` Zhenzhong Duan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200309095102.GA13722@haproxy.com \
    --to=wtarreau@haproxy.com \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jdike@addtoit.com \
    --cc=jonathan@buzzard.org.uk \
    --cc=ksenija.stanojevic@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mpm@selenic.com \
    --cc=pavel@ucw.cz \
    --cc=richard@nod.at \
    --cc=rjw@rjwysocki.net \
    --cc=zhenzhong.duan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).