From: "Pali Rohár" <pali@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: "Andrew F. Davis" <afd@ti.com>,
Sebastian Reichel <sre@kernel.org>,
David Heidelberg <david@ixit.cz>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] power: supply: bq27xxx_battery: Silence deferred-probe error
Date: Tue, 10 Mar 2020 00:06:08 +0100 [thread overview]
Message-ID: <20200309230608.aur2iddomzrdw4pq@pali> (raw)
In-Reply-To: <20200308215143.27823-1-digetx@gmail.com>
On Monday 09 March 2020 00:51:43 Dmitry Osipenko wrote:
> The driver fails to probe with -EPROBE_DEFER if battery's power supply
> (charger driver) isn't ready yet and this results in a bit noisy error
> message in KMSG during kernel's boot up. Let's silence the harmless
> error message.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Hello Dmitry! This change make sense, it is really not an error when
bq27k device registration is deferred. You can add my:
Reviewed-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/power/supply/bq27xxx_battery.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 195c18c2f426..664e50103eaa 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1885,7 +1885,10 @@ int bq27xxx_battery_setup(struct bq27xxx_device_info *di)
>
> di->bat = power_supply_register_no_ws(di->dev, psy_desc, &psy_cfg);
> if (IS_ERR(di->bat)) {
> - dev_err(di->dev, "failed to register battery\n");
> + if (PTR_ERR(di->bat) == -EPROBE_DEFER)
> + dev_dbg(di->dev, "failed to register battery, deferring probe\n");
> + else
> + dev_err(di->dev, "failed to register battery\n");
> return PTR_ERR(di->bat);
> }
>
next prev parent reply other threads:[~2020-03-09 23:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 21:51 [PATCH v1] power: supply: bq27xxx_battery: Silence deferred-probe error Dmitry Osipenko
2020-03-09 12:51 ` Andrew F. Davis
2020-03-09 23:06 ` Pali Rohár [this message]
2020-03-10 13:21 ` Dmitry Osipenko
2020-03-11 22:14 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309230608.aur2iddomzrdw4pq@pali \
--to=pali@kernel.org \
--cc=afd@ti.com \
--cc=david@ixit.cz \
--cc=digetx@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).