From: Richard Cochran <richardcochran@gmail.com>
To: Andrea Righi <andrea.righi@canonical.com>
Cc: Vladis Dronov <vdronov@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ptp: free ptp clock properly
Date: Mon, 9 Mar 2020 19:57:37 -0700 [thread overview]
Message-ID: <20200310025737.GB1679@localhost> (raw)
In-Reply-To: <20200309172238.GJ267906@xps-13>
On Mon, Mar 09, 2020 at 06:22:38PM +0100, Andrea Righi wrote:
> There is a bug in ptp_clock_unregister() where pps_unregister_source()
> can free up resources needed by posix_clock_unregister() to properly
> destroy a related sysfs device.
This text is inadequate. It does not identify the problem. What
resources? Which related device?
> Fix this by calling pps_unregister_source() in ptp_clock_release().
This statement is redundant, as we can see that from the patch itself.
Instead of saying WHAT the patch does, please explain WHY that fixes
the issue (which, as I said, you still need to identify).
Thanks,
Richard
next prev parent reply other threads:[~2020-03-10 2:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 17:22 [PATCH v2] ptp: free ptp clock properly Andrea Righi
2020-03-10 2:57 ` Richard Cochran [this message]
2020-04-03 13:34 ` Vladis Dronov
2020-04-07 9:34 ` Andrea Righi
2020-04-07 10:05 ` Vladis Dronov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310025737.GB1679@localhost \
--to=richardcochran@gmail.com \
--cc=andrea.righi@canonical.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).