From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6669C10F27 for ; Tue, 10 Mar 2020 11:08:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E8B12467F for ; Tue, 10 Mar 2020 11:08:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="ZySw3lnm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726378AbgCJLIA (ORCPT ); Tue, 10 Mar 2020 07:08:00 -0400 Received: from mail.skyhub.de ([5.9.137.197]:50750 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726186AbgCJLIA (ORCPT ); Tue, 10 Mar 2020 07:08:00 -0400 Received: from zn.tnic (p200300EC2F09B4000CCA2EEF87DC47A5.dip0.t-ipconnect.de [IPv6:2003:ec:2f09:b400:cca:2eef:87dc:47a5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BF4E61EC0273; Tue, 10 Mar 2020 12:07:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1583838478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=NLbmp6bW9B7OsLKSubj4LOvRjmIgDRbX4DKrnaThSj8=; b=ZySw3lnmctyl8oeUPZzrtCq2JhRmON6AyovzV9gGKlp/OcXDigwH4UHCnrBhGlH2irE8X4 xSyRiOjcRh+tVgmMKAymn84+KtNuTQbtU6cbUCvsdccF+vDv7ub/vDUqPBuR/fKEtW+jyF bWeBJYlq8dTciyrngPgDuBLU8ccMjbU= Date: Tue, 10 Mar 2020 12:08:02 +0100 From: Borislav Petkov To: Alexandre Chartre Cc: Thomas Gleixner , LKML , x86@kernel.org, Steven Rostedt , Brian Gerst , Juergen Gross , Frederic Weisbecker Subject: Re: [patch part-II V2 08/13] tracing: Provide lockdep less trace_hardirqs_on/off() variants Message-ID: <20200310110802.GC29372@zn.tnic> References: <20200308222359.370649591@linutronix.de> <20200308222609.731890049@linutronix.de> <07a50582-1c2f-7f45-c7dd-5ff9c2ff3052@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <07a50582-1c2f-7f45-c7dd-5ff9c2ff3052@oracle.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2020 at 11:55:57AM +0100, Alexandre Chartre wrote: > Shouldn't trace_hardirqs_on() be updated to call __trace_hardirqs_on()? It's the same > code except for the lockdep call. Fell into that one too initially. Look again. :) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette