LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org,
	Khouloud Touil <ktouil@baylibre.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [PATCH 07/14] nvmem: release the write-protect pin
Date: Tue, 10 Mar 2020 13:22:50 +0000
Message-ID: <20200310132257.23358-8-srinivas.kandagatla@linaro.org> (raw)
In-Reply-To: <20200310132257.23358-1-srinivas.kandagatla@linaro.org>

From: Khouloud Touil <ktouil@baylibre.com>

Put the write-protect GPIO descriptor in nvmem_release() so that it can
be automatically released when the associated device's reference count
drops to 0.

Fixes: 2a127da461a9 ("nvmem: add support for the write-protect pin")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Khouloud Touil <ktouil@baylibre.com>
[Bartosz: tweak the commit message]
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/nvmem/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 2758d90d63b7..c05c4f4a7b9e 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -72,6 +72,7 @@ static void nvmem_release(struct device *dev)
 	struct nvmem_device *nvmem = to_nvmem_device(dev);
 
 	ida_simple_remove(&nvmem_ida, nvmem->id);
+	gpiod_put(nvmem->wp_gpio);
 	kfree(nvmem);
 }
 
-- 
2.21.0


  parent reply index

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 13:22 [PATCH 00/14] nvmem: patches for 5.7 Srinivas Kandagatla
2020-03-10 13:22 ` [PATCH 01/14] nvmem: imx: ocotp: add i.MX8MP support Srinivas Kandagatla
2020-03-10 13:22 ` [PATCH 02/14] nvmem: core: add nvmem_cell_read_common Srinivas Kandagatla
2020-03-10 13:22 ` [PATCH 03/14] nvmem: core: add nvmem_cell_read_u64 Srinivas Kandagatla
2020-03-10 13:22 ` [PATCH 04/14] nvmem: remove a stray newline in nvmem_register() Srinivas Kandagatla
2020-03-10 13:22 ` [PATCH 05/14] nvmem: add a newline for readability Srinivas Kandagatla
2020-03-10 13:22 ` [PATCH 06/14] nvmem: fix memory leak in error path Srinivas Kandagatla
2020-03-10 13:22 ` Srinivas Kandagatla [this message]
2020-03-10 13:22 ` [PATCH 08/14] nvmem: core: validate nvmem config before parsing Srinivas Kandagatla
2020-03-10 13:22 ` [PATCH 09/14] nvmem: check for NULL reg_read and reg_write before dereferencing Srinivas Kandagatla
2020-03-10 13:22 ` [PATCH 10/14] nvmem: imx-ocotp: Drop unnecessary initializations Srinivas Kandagatla
2020-03-10 13:22 ` [PATCH 11/14] Bindings: nvmem: add bindings for JZ4780 efuse Srinivas Kandagatla
2020-03-10 13:22 ` [PATCH 12/14] nvmem: add driver " Srinivas Kandagatla
2020-03-10 13:22 ` [PATCH 13/14] Documentation: ABI: nvmem: add documentation for JZ4780 efuse ABI Srinivas Kandagatla
2020-03-10 13:22 ` [PATCH 14/14] nvmem: jz4780-efuse: fix build warnings on ARCH=x86_64 or riscv Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200310132257.23358-8-srinivas.kandagatla@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ktouil@baylibre.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git