From: Boris Brezillon <boris.brezillon@collabora.com>
To: Mason Yang <masonccyang@mxic.com.tw>
Cc: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
frieder.schrempf@kontron.de, tglx@linutronix.de, stefan@agner.ch,
juliensu@mxic.com.tw, allison@lohutok.net,
linux-kernel@vger.kernel.org, bbrezillon@kernel.org,
rfontana@redhat.com, linux-mtd@lists.infradead.org,
yuehaibing@huawei.com, s.hauer@pengutronix.de
Subject: Re: [PATCH v3 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume operation
Date: Tue, 10 Mar 2020 20:41:42 +0100 [thread overview]
Message-ID: <20200310204142.540fc7c4@collabora.com> (raw)
In-Reply-To: <20200310203930.2b8c0cfb@collabora.com>
On Tue, 10 Mar 2020 20:39:30 +0100
Boris Brezillon <boris.brezillon@collabora.com> wrote:
> On Tue, 3 Mar 2020 15:21:23 +0800
> Mason Yang <masonccyang@mxic.com.tw> wrote:
>
> > Patch nand_suspend() & nand_resume() for manufacturer specific
> > suspend/resume operation.
> >
> > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > drivers/mtd/nand/raw/nand_base.c | 11 ++++++++---
> > include/linux/mtd/rawnand.h | 4 ++++
> > 2 files changed, 12 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> > index 769be81..b44e460 100644
> > --- a/drivers/mtd/nand/raw/nand_base.c
> > +++ b/drivers/mtd/nand/raw/nand_base.c
> > @@ -4327,7 +4327,9 @@ static int nand_suspend(struct mtd_info *mtd)
> > struct nand_chip *chip = mtd_to_nand(mtd);
> >
> > mutex_lock(&chip->lock);
> > - chip->suspended = 1;
> > + if (chip->_suspend)
> > + if (!chip->_suspend(chip))
> > + chip->suspended = 1;
Shouldn't you propagate the error to the caller if chip->_suspend()
fails?
next prev parent reply other threads:[~2020-03-10 19:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 7:21 [PATCH v3 0/4] mtd: rawnand: Add support Macronix Block Portection & Deep Power Down mode Mason Yang
2020-03-03 7:21 ` [PATCH v3 1/4] mtd: rawnand: Add support manufacturer specific lock/unlock operation Mason Yang
2020-03-10 18:30 ` Miquel Raynal
2020-03-10 19:27 ` Boris Brezillon
2020-03-11 2:40 ` masonccyang
2020-03-11 7:25 ` Miquel Raynal
2020-03-03 7:21 ` [PATCH v3 2/4] mtd: rawnand: Add support Macronix Block Protection function Mason Yang
2020-03-03 7:21 ` [PATCH v3 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume operation Mason Yang
2020-03-10 18:30 ` Miquel Raynal
2020-03-10 19:33 ` Boris Brezillon
2020-03-11 5:40 ` masonccyang
2020-03-11 7:43 ` Miquel Raynal
2020-03-11 7:56 ` Boris Brezillon
2020-03-12 1:45 ` masonccyang
2020-03-10 19:39 ` Boris Brezillon
2020-03-10 19:41 ` Boris Brezillon [this message]
2020-03-11 6:13 ` masonccyang
2020-03-11 8:01 ` Boris Brezillon
2020-03-12 1:48 ` masonccyang
2020-03-03 7:21 ` [PATCH v3 4/4] mtd: rawnand: Add support Macronix deep power down mode Mason Yang
2020-03-09 13:14 ` [PATCH v3 0/4] mtd: rawnand: Add support Macronix Block Portection & Deep Power Down mode Miquel Raynal
2020-03-10 2:30 ` masonccyang
2020-03-10 7:44 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310204142.540fc7c4@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=allison@lohutok.net \
--cc=bbrezillon@kernel.org \
--cc=frieder.schrempf@kontron.de \
--cc=juliensu@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=rfontana@redhat.com \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
--cc=stefan@agner.ch \
--cc=tglx@linutronix.de \
--cc=vigneshr@ti.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).