From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60477C18E5B for ; Tue, 10 Mar 2020 22:41:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C3C8205C9 for ; Tue, 10 Mar 2020 22:41:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727800AbgCJWlE (ORCPT ); Tue, 10 Mar 2020 18:41:04 -0400 Received: from vmicros1.altlinux.org ([194.107.17.57]:58882 "EHLO vmicros1.altlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbgCJWlE (ORCPT ); Tue, 10 Mar 2020 18:41:04 -0400 Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 236F272CCF0; Wed, 11 Mar 2020 01:41:01 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 1A1F07CC7FF; Wed, 11 Mar 2020 01:41:01 +0300 (MSK) Date: Wed, 11 Mar 2020 01:41:01 +0300 From: "Dmitry V. Levin" To: Bernd Edlinger Cc: "Eric W. Biederman" , Christian Brauner , Kees Cook , Jann Horn , Jonathan Corbet , Alexander Viro , Andrew Morton , Alexey Dobriyan , Thomas Gleixner , Oleg Nesterov , Frederic Weisbecker , Andrei Vagin , Ingo Molnar , "Peter Zijlstra (Intel)" , Yuyang Du , David Hildenbrand , Sebastian Andrzej Siewior , Anshuman Khandual , David Howells , James Morris , Greg Kroah-Hartman , Shakeel Butt , Jason Gunthorpe , Christian Kellner , Andrea Arcangeli , Aleksa Sarai , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "stable@vger.kernel.org" , "linux-api@vger.kernel.org" Subject: Re: [PATCH 2/4] selftests/ptrace: add test cases for dead-locks Message-ID: <20200310224100.GA1563@altlinux.org> References: <878sk94eay.fsf@x220.int.ebiederm.org> <87r1y12yc7.fsf@x220.int.ebiederm.org> <87k13t2xpd.fsf@x220.int.ebiederm.org> <87d09l2x5n.fsf@x220.int.ebiederm.org> <871rq12vxu.fsf@x220.int.ebiederm.org> <877dzt1fnf.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2020 at 02:44:01PM +0100, Bernd Edlinger wrote: > This adds test cases for ptrace deadlocks. > > Additionally fixes a compile problem in get_syscall_info.c, > observed with gcc-4.8.4: > > get_syscall_info.c: In function 'get_syscall_info': > get_syscall_info.c:93:3: error: 'for' loop initial declarations are only > allowed in C99 mode > for (unsigned int i = 0; i < ARRAY_SIZE(args); ++i) { > ^ > get_syscall_info.c:93:3: note: use option -std=c99 or -std=gnu99 to compile > your code [...] > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0-only > -CFLAGS += -iquote../../../../include/uapi -Wall > +CFLAGS += -std=c99 -pthread -iquote../../../../include/uapi -Wall Wouldn't it be better to choose -std=gnu99 over -std=c99? -- ldv