From: Luis Chamberlain <mcgrof@kernel.org>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Eric Biggers <ebiggers@kernel.org>, NeilBrown <neilb@suse.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
stable@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jeff Vander Stoep <jeffv@google.com>,
Jessica Yu <jeyu@kernel.org>, Kees Cook <keescook@chromium.org>,
benh@debian.org
Subject: Re: [PATCH] kmod: make request_module() return an error when autoloading is disabled
Date: Wed, 11 Mar 2020 06:32:14 +0000 [thread overview]
Message-ID: <20200311063214.GM11244@42.do-not-panic.com> (raw)
In-Reply-To: <0256C870-590C-426A-B4DF-4C272E46B75F@joshtriplett.org>
On Wed, Mar 11, 2020 at 06:55:30AM +0100, Josh Triplett wrote:
> On March 11, 2020 5:32:21 AM GMT+01:00, Luis Chamberlain <mcgrof@kernel.org> wrote:
> >On Tue, Mar 10, 2020 at 03:37:31PM -0700, Eric Biggers wrote:
> >> However, request_module() should also
> >> correctly return an error when it fails. So let's make it return
> >> -ENOENT, which matches the error when the modprobe binary doesn't
> >exist.
> >
> >This is a user experience change though, and I wouldn't have on my
> >radar
> >who would use this, and expects the old behaviour. Josh, would you by
> >chance?
>
> I don't think this affects userspace. But I'd suggest Ben Hutchings (CCed).
It doesn't, so yes no verififcation needed. Thanks the quick response though!
Luis
next prev parent reply other threads:[~2020-03-11 6:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 22:37 [PATCH] kmod: make request_module() return an error when autoloading is disabled Eric Biggers
2020-03-11 4:32 ` Luis Chamberlain
2020-03-11 5:26 ` Eric Biggers
2020-03-11 6:31 ` Luis Chamberlain
2020-03-11 17:35 ` Eric Biggers
2020-03-11 18:00 ` Luis Chamberlain
2020-03-11 18:21 ` Eric Biggers
2020-03-11 18:40 ` Luis Chamberlain
2020-03-11 5:55 ` Josh Triplett
2020-03-11 6:32 ` Luis Chamberlain [this message]
2020-03-11 17:28 ` Kees Cook
2020-03-11 17:41 ` Eric Biggers
2020-03-11 17:50 ` Kees Cook
2020-03-11 18:01 ` Luis Chamberlain
2020-03-11 18:08 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311063214.GM11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=benh@debian.org \
--cc=ebiggers@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeffv@google.com \
--cc=jeyu@kernel.org \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).