From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 993F9C4CC9E for ; Wed, 11 Mar 2020 18:54:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 698BD206BE for ; Wed, 11 Mar 2020 18:54:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Xu0YYNq6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731006AbgCKSyI (ORCPT ); Wed, 11 Mar 2020 14:54:08 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:41551 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730988AbgCKSyG (ORCPT ); Wed, 11 Mar 2020 14:54:06 -0400 Received: by mail-pg1-f196.google.com with SMTP id b1so1676787pgm.8 for ; Wed, 11 Mar 2020 11:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+NFtzlNIubXyKkT0aaqAyTYGNu2hBMxpytJJLWrkR+w=; b=Xu0YYNq6iL3XItsLJITZiAfw7pQ55+Wan446ePi0MQv+K8wkXn4aRCAf4e5Emt+HlC hKXOCC/w+kuvCqACGDt+jTb/a6HCI7Gwm6wXsgSTYmC6M16yXJO58tUwc7cQNtetwc/Z JdAJWbhaOAvARZcMbagpxGBlTJO9eEMDFM22E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+NFtzlNIubXyKkT0aaqAyTYGNu2hBMxpytJJLWrkR+w=; b=ep5NbKpW8bF49PrKJh4mzGBCgx8hf5VcddYIKihcyPkejA+HkWnz0B0m20qdR1mHEo njm3O9htQSkpbIeiwNzgM5GJkZc4DvS4v2eGprXMhlzTlinaauwW117r9Fkxx/GZzI7p bbj6xc6dmHeKo4NlylIjOBbMd7ExmmMHw7orM0x4KT/YRHT7nhIBRWNdykmntPzzu0zO LKuFQP4UvnU4/f7q1LHw5CYOh8OTONpYPQXORwgM97KN3NDXUj/Oqvala+eeh84dsBH1 KkUXqsiNprrJDCpQ5RONAdYz8hxrBOEXHaSlkEehkiEi2NCZ9i6buD0FX6zYukgmS2PG //PQ== X-Gm-Message-State: ANhLgQ2nsfWaqUU3c78ZPLMz/RFulvti1oAMBadfmMV4dOV++4l66u4g pOEFFXmFq7BmHnpWm1RLX6vtNg== X-Google-Smtp-Source: ADFU+vtdcKOyGaZUfwI5+MQMZZomjwrU/L0V+T9gd4shCDOL0PoNkiwaShk91h0o8jLRtEUWUh1JTA== X-Received: by 2002:a63:b04f:: with SMTP id z15mr4044123pgo.58.1583952845893; Wed, 11 Mar 2020 11:54:05 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z24sm19444621pfk.46.2020.03.11.11.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 11:54:05 -0700 (PDT) Date: Wed, 11 Mar 2020 11:54:04 -0700 From: Kees Cook To: Bernd Edlinger Cc: "Eric W. Biederman" , Christian Brauner , Jann Horn , Jonathan Corbet , Alexander Viro , Andrew Morton , Alexey Dobriyan , Thomas Gleixner , Oleg Nesterov , Frederic Weisbecker , Andrei Vagin , Ingo Molnar , "Peter Zijlstra (Intel)" , Yuyang Du , David Hildenbrand , Sebastian Andrzej Siewior , Anshuman Khandual , David Howells , James Morris , Greg Kroah-Hartman , Shakeel Butt , Jason Gunthorpe , Christian Kellner , Andrea Arcangeli , Aleksa Sarai , "Dmitry V. Levin" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "stable@vger.kernel.org" , "linux-api@vger.kernel.org" Subject: Re: [PATCH 4/4] kernel: doc: remove outdated comment cred.c Message-ID: <202003111154.AEA9260278@keescook> References: <878sk94eay.fsf@x220.int.ebiederm.org> <87r1y12yc7.fsf@x220.int.ebiederm.org> <87k13t2xpd.fsf@x220.int.ebiederm.org> <87d09l2x5n.fsf@x220.int.ebiederm.org> <871rq12vxu.fsf@x220.int.ebiederm.org> <877dzt1fnf.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2020 at 02:44:18PM +0100, Bernd Edlinger wrote: > This removes an outdated comment in prepare_kernel_cred. > > There is no "cred_replace_mutex" any more, so the comment must > go away. > > Signed-off-by: Bernd Edlinger Reviewed-by: Kees Cook -Kees > --- > kernel/cred.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kernel/cred.c b/kernel/cred.c > index 809a985..71a7926 100644 > --- a/kernel/cred.c > +++ b/kernel/cred.c > @@ -675,8 +675,6 @@ void __init cred_init(void) > * The caller may change these controls afterwards if desired. > * > * Returns the new credentials or NULL if out of memory. > - * > - * Does not take, and does not return holding current->cred_replace_mutex. > */ > struct cred *prepare_kernel_cred(struct task_struct *daemon) > { > -- > 1.9.1 -- Kees Cook